Opened 9 months ago

Last modified 4 months ago

#27245 accepted defect

Don't store (micro)descriptor text on the heap so much.

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 035-roadmap-master, 035-triaged-in-20180711
Cc: Actual Points:
Parent ID: #27243 Points:
Reviewer: Sponsor:

Description

We could use less RAM for our (micro)descriptor text if we kept the .new file mmapped, so that we didn't need to use the heap to hold them.

Child Tickets

Change History (5)

comment:1 Changed 9 months ago by nickm

Owner: set to nickm
Status: newaccepted

comment:2 Changed 9 months ago by nickm

after some exploratory work and re-analysis, I think it might be a good idea to defer this. In the profiles, we spent on average .7 MB (3% of the directory allocations) on microdescriptor bodies. There are other places we should improve first.

comment:3 Changed 9 months ago by nickm

Sponsor: Sponsor8Sponsor8-can

I'm leaving my work-in-progress in a branch called ticket27245 so I don't forget about it.

comment:4 Changed 9 months ago by nickm

Milestone: Tor: 0.3.5.x-finalTor: unspecified

comment:5 Changed 4 months ago by gaba

Sponsor: Sponsor8-can
Note: See TracTickets for help on using tickets.