Opened 9 years ago

Closed 8 years ago

#2725 closed defect (fixed)

Do not overwrite custom added exit policies

Reported by: chiiph Owned by: chiiph
Priority: Medium Milestone: Vidalia: 0.3.x
Component: Archived/Vidalia Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Migrated from old trac:
"This is mainly inspired by the resolved 333. At the moment additions to the exit policy list made by user outside Vidalia are discarded when .TORRC is saved again due some parameters being changed inside Vidalia.
Example: if I currently have set exit policy to only "instant messengers" in Vidalia, add by hand port 5223 to .TORRC, then run Vidalia, change for example the allowed bandwidth and save then I get the standard "IM" exit ports, effectivly undoing the modification I made previously to the policy.

Vidalia already does a great deal parsing .TORRC (even adding comments to several parameters), would be nice if also the exit policy would be checked so that unknown ports wouldn't be overwritten. Ideally the GUI could include some sort of indicator which would hint that the configuration file features settings which affect TOR's behaviour, but aren't configurable/supported by the GUI (Vidalia)."

Child Tickets

Change History (4)

comment:1 Changed 9 years ago by arma

Definitely worth fixing, but not super high priority since it only affects people who modify their torrc file manually.

Maybe it could be done through a "custom" checkbox in the exit policies tab? The simple version would be that it sets the custom box when it finds that your exit policy doesn't fit into the other boxes, and if the custom box is set then it doesn't overwrite your exit policy when you click save. The more complex version would be to have a 'custom' box you can check and then it lets you edit your exit policy lines right there.

Or maybe those are silly ideas and we need to come up with a better plan.

comment:2 Changed 9 years ago by chiiph

Milestone: Vidalia-0.3.X

comment:3 Changed 9 years ago by chiiph

The problem here is that Vidalia handles the exit policies in vidalia.conf, and it applies them when it attaches to a running Tor instance (disregarding any other policy already there).

Here we are with another problem of config priority. I'd expect Vidalia to properly modify torrc rather than putting that config in vidalia.conf.

I think I'll leave this change out of the 0.3.0 release, and I'll make Vidalia save all Tor's configurations in its torrc and everything Vidalia-only in vidalia.conf.

comment:4 Changed 8 years ago by chiiph

Resolution: fixed
Status: newclosed

This has been fixed in my branch chiiph/featSettings, where Vidalia uses the torrc file to handle tor's config. It'll go out with 0.3.2-alpha.

Note: See TracTickets for help on using tickets.