Opened 4 months ago

Closed 3 weeks ago

Last modified 41 hours ago

#27256 closed defect (fixed)

Android specific about:config preferences

Reported by: towiw Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Major Keywords: tbb-mobile, TBA-a2, TorBrowserTeam201811R
Cc: mtristan Actual Points:
Parent ID: Points:
Reviewer: Sponsor: Sponsor8

Description

For text selection to work on TBA, dom.w3c_touch_events.enabled needs to be set to 1 or 2. There could be more preferences that need to be adjusted for TBA.

Child Tickets

Change History (13)

comment:1 Changed 4 months ago by towiw

Not really related but network.dns.blockDotOnion is currently set to true in TBA. It should be changed to false.

comment:2 Changed 4 months ago by towiw2

Ignore my last comment.

comment:3 Changed 4 months ago by sysrqb

Parent ID: #26531
Status: newneeds_information

We should correct this in the alpha release (but not necessarily first alpha). Indeed, text selection is buggy/does not work in my test builds. However, seeing dom.w3c_touch_events.enabled doesn't solve the problem. I think more investigation is needed here.

comment:4 Changed 4 months ago by sysrqb

err, s/seeing/setting/

comment:5 Changed 3 months ago by towiw3

@ sysrqb, you need to restart TBA for it to take effect.

comment:6 Changed 3 months ago by sysrqb

Keywords: TBA-a2 added
Parent ID: #26531

Moving to second-alpha TBA keyword.

comment:7 Changed 2 months ago by gk

Keywords: TorBrowserTeam201810 added

Putting on October radar.

comment:8 Changed 5 weeks ago by gk

Keywords: TorBrowserTeam201811 added; TorBrowserTeam201810 removed

Moving our tickets to November.

comment:9 Changed 5 weeks ago by gk

Cc: mtristan added

Resolved #28343 as duplicate.

comment:10 Changed 4 weeks ago by sysrqb

Status: needs_informationneeds_review

Okay. I know I tested this before and it didn't work, but maybe it required starting the app and I didn't do that (?). In any case, setting that pref does seem like a fix. The pref is used at dom/events/TouchEvent.cpp:196

I have a branch for review: 27256.

Thanks towiw.

comment:11 Changed 4 weeks ago by gk

Keywords: TorBrowserTeam201811R added; TorBrowserTeam201811 removed

comment:12 Changed 3 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Fixed with commit 0b188f1fd0349fc76f8cc5663279a67b283d3b68 on tor-browser-60.3.0esr-8.5-1.

comment:13 Changed 41 hours ago by gk

Sponsor: Sponsor8

Sponsor 8 work.

Note: See TracTickets for help on using tickets.