Bookmark items are not visible on the bookmarks toolbar

A user reported on the blog that bookmark items are not visible on the bookmark toolbar when making it visible. This affects all platforms it seems and does not happen in Firefox 60.1.0esr. See: https://blog.torproject.org/comment/276473#comment-276473 for the report.

added AffectsTails GeorgKoppen201809 TorBrowserTeam201809R component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::normal status::closed tbb-8.0-issues tbb-8.0.1-can tbb-regression type::defect labels

I did a few experiments on macOS while waiting for a browser build to finish. Here is what I learned:

• This problem does not seem to occur in 8.0a9.
• In 8.0a10, disabling all extensions does not help.
• In 8.0a10, the problem disappeared after I went to View|Toolbars|Customize... and clicked "Restore Defaults".

Trac:
Keywords: ff60-esr deleted, tbb-regression, tbb-8.0-issues added

Marking for 8.0.1 can.

Trac:
Keywords: N/A deleted, tbb-8.0.1-can added

Trac:
Keywords: N/A deleted, GeorgKoppen201809 added

bug_27264 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_27264&id=1d974fa2b70dfe07bea896c99c88d7f62f3268a5) in my public tor-browser repo has a fix for review. That might not solve the problem for users that are already on 8.0 because the original value of browser.uiCustomization.state gets saved in the profile dir in prefs.js as a user pref. On the other hand, the update happened "properly" for those that were on 7.5.6 before... Anyway, I think there is not much we can do than adding the missing \"personal-bookmarks\" item.

Trac:
Keywords: N/A deleted, TorBrowserTeam201809R added
Status: new to needs_review

Replying to gk:

bug_27264 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_27264&id=1d974fa2b70dfe07bea896c99c88d7f62f3268a5) in my public tor-browser repo has a fix for review.

Looks good to me.

Trac:
Status: needs_review to merge_ready

Thanks! Merged to tor-browser-60.2.0esr-8.5-1 (commit 1d974fa2b70dfe07bea896c99c88d7f62f3268a5) and cherry-picked to tor-browser-60.2.0esr-8.0-1 (commit 3444c43fc135f68a2da2ebcded8c0adb89254f3f).

Trac:
Resolution: N/A to fixed
Status: merge_ready to closed

#27767 (moved) is a duplicate.

Trac:
Keywords: N/A deleted, AffectsTails added
Cc: N/A to goupille, intrigeri

closed

mentioned in issue #27767 (moved)

mentioned in issue #27768 (moved)

moved to tpo/applications/tor-browser#27264 (closed)