#27266 closed defect (fixed)

Links to IP addresses in same /24 are broken

Reported by: karsten Owned by: metrics-team
Priority: Medium Milestone:
Component: Metrics/ExoneraTor Version:
Severity: Normal Keywords:
Cc: metrics-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When a result is negative but there are IP addresses of relays in the same /24, we're printing out links to those searches. However, those searches are currently broken since moving ExoneraTor to Tor Metrics. I'm not fixing this right away, because I'd like to get the #27234 changes merged first. Should be okay to wait another week.

Child Tickets

Change History (7)

comment:1 Changed 11 months ago by karsten

Status: newneeds_review

comment:2 Changed 11 months ago by irl

Status: needs_reviewmerge_ready

Ok. Looks good to me.

comment:3 Changed 11 months ago by karsten

Status: merge_readyneeds_review

Great! Please also take a look at the two new commits in that same branch that prepare the release, and check whether the following pre-release tarball looks okay to you:

https://people.torproject.org/~karsten/volatile/exonerator-3.0.1-pre0.tar.gz

comment:4 Changed 11 months ago by irl

Status: needs_reviewmerge_ready

Looks good to me mostly, although a certificate has changed with no explanation as to why.

comment:5 Changed 11 months ago by karsten

Thanks for checking! I updated the certificate, because the old certificate had expired. I'm doing that every three months and copying over the certificate to the other code bases whenever putting out the next release. That's why.

Merged to master, tagged, released, deployed. Do we want to put out a release announcement? I guess not, but I don't feel strongly. Leaving open for the announcement decision only.

comment:6 Changed 11 months ago by irl

Ok. We should discuss in Mexico how these certificates are handled and how to bootstrap trust in them. It may be that when we come to automating some deployments we want to verify the signatures but this would need to be done automatically.

I think a quick mail would be good, especially as this fixes a bug that was raised by a user, not just found internally.

comment:7 in reply to:  6 Changed 11 months ago by karsten

Resolution: fixed
Status: merge_readyclosed

Replying to irl:

Ok. We should discuss in Mexico how these certificates are handled and how to bootstrap trust in them. It may be that when we come to automating some deployments we want to verify the signatures but this would need to be done automatically.

Sounds good to me.

I think a quick mail would be good, especially as this fixes a bug that was raised by a user, not just found internally.

Ah, I sent the last announcement, so I should be sending this one, too. Done.

Closing. Thanks!

Note: See TracTickets for help on using tickets.