Opened 9 years ago

Closed 8 years ago

#2727 closed enhancement (fixed)

Users should be able to selectively disable or enable panes in the network map

Reported by: chiiph Owned by: sebb
Priority: Medium Milestone:
Component: Archived/Vidalia Version:
Severity: Keywords:
Cc: sebthestampede@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Migrated from old trac:
"Users should be able to selectively disable individual panes in the network map and then resize or rearrange the remaining panes appropriately. This would make room for panes that need more screen real estate, like the connection status pane.

Suggested by dr|z3d."

Child Tickets

Attachments (1)

collapsible.panes.network.map.patch (1.4 KB) - added by sebb 8 years ago.
Here is a patch for "collapsible" option.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 8 years ago by sebb

Cc: sebthestampede@… added
Owner: changed from chiiph to sebb
Status: newassigned

comment:2 Changed 8 years ago by sebb

Status: assignedneeds_review

(1) selectively disable individual panes in the network map
(2) make room for panes that need more screen real estate
IMHO the simplest way to accomplish this is to enable the option to collapse the widgets on the network view window. They sits in the splitters already, so this is straightforward and solves both (1) and (2) easily.
I don't know if you want this to have more options, like saving the view settings between sessions, so I need a comment on this one.

Changed 8 years ago by sebb

Here is a patch for "collapsible" option.

comment:3 Changed 8 years ago by chiiph

Status: needs_reviewneeds_revision

I like the approach, I've never seen this collapsible prop.

A couple of points:

  • The patch should be based on the latest alpha.
  • The state of the panes should be saved.
  • There should be a changes file.

comment:4 Changed 8 years ago by sebb

Status: needs_revisionneeds_review

comment:5 Changed 8 years ago by chiiph

Status: needs_reviewneeds_revision

If we are going to always create settings, we should set the name to General whenever the class doesn't provide one, otherwise we will end up with no section.

Also, you should separate the two issues in separate commits. Otherwise it looks good.

comment:6 Changed 8 years ago by sebb

sure, I'll create separate branches for these two + ticket for settings issue (for changelog entry)
will post the code in the evening

comment:7 Changed 8 years ago by sebb

Status: needs_revisionneeds_review

branch 2727_network_view_panes updated

comment:8 Changed 8 years ago by chiiph

Status: needs_reviewneeds_revision
  • If you are reusing QByteArray state and assigning with getSetting, I think it's better if you just put the getSetting call inside the restoreState call.
  • The changes file is too wide, and it should have the title "New Features:" (check the new changelog layout).

comment:9 Changed 8 years ago by sebb

Status: needs_revisionneeds_review

corrected and committed

comment:10 Changed 8 years ago by chiiph

Resolution: fixed
Status: needs_reviewclosed

Merged, it will be out with 0.3.2.

Note: See TracTickets for help on using tickets.