Don't allow the user to install extensions from web

Tor browser for Android doesn't verify if the torbutton extension has a signature to install it. Thus, if someone sends a tampered torbutton extension to the user, they can install it.

added TorBrowserTeam201808R component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::normal sponsor::8 status::closed tbb-mobile type::defect labels

Trac:
0001-Bug-27271-Don-t-allow-the-user-to-install-extensions.patch

I think for the alpha, the proposed patch is a good solution until we figure out a final one.

https://trac.torproject.org/projects/tor/attachment/ticket/27271/0001-Bug-27271-Don-t-allow-the-user-to-install-extensions.patch

Trac:
Cc: N/A to sysrqb, gk
Status: new to needs_review

Trac:
Cc: sysrqb, gk to sysrqb, gk, dmr

OKay, just setting the pref after start-up and restarting still allows me to install extensions. I need to make a clean build to verify that, I guess.

Trac:
Cc: sysrqb, gk, dmr to sysrqb, gk

Trac:
Cc: sysrqb, gk to sysrqb, gk, dmr

Trac:
0001-Bug-27271-Don-t-allow-the-user-to-install-extensions.2.patch

updated code:

https://trac.torproject.org/projects/tor/attachment/ticket/27271/0001-Bug-27271-Don-t-allow-the-user-to-install-extensions.2.patch

Thanks, this works for me on a fresh build. I am not sure why just adding the prefs does nothing, though. Applied to tor-browser-60.1.0esr-8.0-1 as commit a0620db9e7cd08e3d67a42d0c5b1067d5b3ed355.

Trac:
Resolution: N/A to fixed
Keywords: N/A deleted, tbb-mobile, TorBrowserTeam201808R added
Status: needs_review to closed

igt0, sysrqb: could anyone of you open a follow-up ticket with a plan for fixing the underlying issue better. FWIW: https://bugzilla.mozilla.org/show_bug.cgi?id=1464766 landed in esr60 and might be a thing to consider here.

Replying to gk:

igt0, sysrqb: could anyone of you open a follow-up ticket with a plan for fixing the underlying issue better. FWIW: https://bugzilla.mozilla.org/show_bug.cgi?id=1464766 landed in esr60 and might be a thing to consider here.

I opened #27762 (moved) for that.

Trac:
Sponsor: N/A to Sponsor8

Sponsor8 in August 2018.

closed

mentioned in issue #27762 (moved)

mentioned in issue #28059 (moved)

moved to tpo/applications/tor-browser#27271 (closed)

mentioned in issue tpo/applications/tor-browser#27762 (closed)