Opened 3 months ago

Closed 3 months ago

#27276 closed defect (fixed)

Update security slider to follow NoScript protocol change

Reported by: arthuredelstein Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-security-slider, ff60-esr, TorBrowserTeam201808R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

ma1 wrote:

Please notice that NoScript 10.1.8.17 ​does change its message handling to slightly abstract it, simplify it and fix some subtle bugs.

As a consequence, the property by which all the messages (including updateSettings)identify themselves is not called "type" anymore, but "_messageName".

In order to work with 10.1.8.1.17 and above, the Security Slider must therefore send this the updated policy in an object with a "_messageName": "updateSettings" property (alone, or in addition to the existent "type": "updateSettings" one for backward compatibility).

Child Tickets

Change History (2)

comment:1 Changed 3 months ago by arthuredelstein

Keywords: ff60-esr TorBrowserTeam201808R added
Status: newneeds_review

I also found that the "NoScript." prefix no longer exists. Here's a patch for review:

https://github.com/arthuredelstein/torbutton/commit/27276

comment:2 Changed 3 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good, merged to master (commit aa379dcc5c06ee542a1c63adc769678700e32eaa).

Note: See TracTickets for help on using tickets.