Opened 3 months ago

Closed 3 months ago

#27283 closed defect (fixed)

default uitour permission does not work with 1st party isolation

Reported by: mcs Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201808R
Cc: arthuredelstein Actual Points:
Parent ID: #26962 Points:
Reviewer: Sponsor:

Description

While working on #26962, Kathy and I discovered that first party isolation breaks the behavior of the default uitour permissions (listed in browser/app/permissions). This bug makes it impossible to use a default permission for an https:// site. We have a patch which we will post soon.

Child Tickets

Change History (8)

comment:1 Changed 3 months ago by mcs

Keywords: TorBrowserTeam201808R added; TorBrowserTeam201808 removed
Status: newneeds_review

comment:2 Changed 3 months ago by gk

Do you have an easy example or steps showing the bug, so that we can get a better understanding what broke and check whether your patches fixes it?

comment:3 in reply to:  2 ; Changed 3 months ago by mcs

Replying to gk:

Do you have an easy example or steps showing the bug, so that we can get a better understanding what broke and check whether your patches fixes it?

For testing, it might be easiest to wait until we post the patch for #26962 (coming very soon).

comment:4 in reply to:  3 Changed 3 months ago by mcs

Replying to mcs:

For testing, it might be easiest to wait until we post the patch for #26962 (coming very soon).

Those patches are available now; please see ticket:26962#comment:6.

comment:5 in reply to:  3 Changed 3 months ago by gk

Replying to mcs:

Replying to gk:

Do you have an easy example or steps showing the bug, so that we can get a better understanding what broke and check whether your patches fixes it?

For testing, it might be easiest to wait until we post the patch for #26962 (coming very soon).

Indeed, thanks. Your patch works for me and looks good. Arthur, could you have a look at it as well as you wrote #25169?

comment:6 Changed 3 months ago by gk

(Meanwhile I landed this on tor-browser-60.1.0esr-8.0-1 (commit d55b7bb578cf644e780d27efa2355c2046bcf689) to get nightly builds going with it, but I'd still like to have a second review)

comment:7 Changed 3 months ago by arthuredelstein

Looks good to me. Thanks!

comment:8 Changed 3 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks, closing then.

Note: See TracTickets for help on using tickets.