default uitour permission does not work with 1st party isolation

While working on #26962 (moved), Kathy and I discovered that first party isolation breaks the behavior of the default uitour permissions (listed in browser/app/permissions). This bug makes it impossible to use a default permission for an https:// site. We have a patch which we will post soon.

added TorBrowserTeam201808R component::applications/tor browser owner::tbb-team parent::26962 priority::very high resolution::fixed severity::normal status::closed type::defect labels

Here is a patch for review: https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug26962-01&id=c5c5e609beffd676ff699bd7a6e0ccbe21e19610

Trac:
Status: new to needs_review
Keywords: TorBrowserTeam201808 deleted, TorBrowserTeam201808R added

Do you have an easy example or steps showing the bug, so that we can get a better understanding what broke and check whether your patches fixes it?

Replying to gk:

Do you have an easy example or steps showing the bug, so that we can get a better understanding what broke and check whether your patches fixes it?

For testing, it might be easiest to wait until we post the patch for #26962 (moved) (coming very soon).

Replying to mcs:

For testing, it might be easiest to wait until we post the patch for #26962 (moved) (coming very soon).

Those patches are available now; please see ticket:26962#comment:6.

Replying to mcs:

Replying to gk:

Do you have an easy example or steps showing the bug, so that we can get a better understanding what broke and check whether your patches fixes it?

For testing, it might be easiest to wait until we post the patch for #26962 (moved) (coming very soon).

Indeed, thanks. Your patch works for me and looks good. Arthur, could you have a look at it as well as you wrote #25169 (moved)?

(Meanwhile I landed this on tor-browser-60.1.0esr-8.0-1 (commit d55b7bb578cf644e780d27efa2355c2046bcf689) to get nightly builds going with it, but I'd still like to have a second review)

Looks good to me. Thanks!

Thanks, closing then.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

moved to tpo/applications/tor-browser#27283 (closed)