Opened 7 months ago

Last modified 3 weeks ago

#27284 assigned defect

Check IPv6 exit policies on microdescs

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: ipv6, 040-deferred-20190220, teor-unreached-2019-03-08
Cc: dgoulet, intrigeri Actual Points:
Parent ID: #27248 Points:
Reviewer: Sponsor:

Description

In node_exit_policy_rejects_all(), we check IPv4 and IPv6 policies on ri, but on md we only check IPv4:

  else if (node->md)
    return node->md->exit_policy == NULL ||
      short_policy_is_reject_star(node->md->exit_policy);

One way to fix this issue is to refactor the existing code to check a new policy_is_reject_star, and then populate policy_is_reject_star when the md is parsed. (Like we already do with the ri.)

Child Tickets

Change History (8)

comment:1 Changed 7 months ago by teor

Parent ID: #27236#27080

Flatten the tree

comment:2 Changed 7 months ago by teor

Keywords: ipv6 added
Milestone: Tor: 0.3.5.x-finalTor: 0.3.6.x-final

Defer to 0.3.6, because it doesn't have any clear benefit in 0.3.5 just before a freeze.

comment:3 Changed 7 months ago by teor

Parent ID: #27080

Un-parenting, it's not required for 0.3.4.

comment:4 Changed 5 months ago by teor

Keywords: 034-backport-maybe removed

comment:5 Changed 5 months ago by nickm

Milestone: Tor: 0.3.6.x-finalTor: 0.4.0.x-final

Tor 0.3.6.x has been renamed to 0.4.0.x.

comment:6 Changed 3 months ago by teor

Parent ID: #27248

#27248 would also fix this issue, and many similar issues.

comment:7 Changed 5 weeks ago by nickm

Keywords: 040-deferred-20190220 added
Milestone: Tor: 0.4.0.x-finalTor: unspecified

Deferring 51 tickets from 0.4.0.x-final. Tagging them with 040-deferred-20190220 for visibility. These are the tickets that did not get 040-must, 040-can, or tor-ci.

comment:8 Changed 3 weeks ago by teor

Keywords: teor-unreached-2019-03-08 added
Owner: teor deleted

I'd like to do these tickets, but not in the next few months.

Note: See TracTickets for help on using tickets.