Tor with NSS must not claim to support LinkAuth=1

LinkAuth=1 is the older one that pokes inside the world of TLS master secrets. NSS sensibly doesn't let us do that, and makes us use RFC5705 like sensible people.

We shouldn't claim to support it, though.

I'm making this a separate ticket from the rest of NSS-TLS, though, since once we merge this, Tor clients and servers will stop working with NSS until #27286 (moved) is merged to update the list of required protocols.

changed milestone to %Tor: 0.3.5.x-final

added 035-roadmap-master 035-triaged-in-20180711 component::core tor/tor milestone::Tor: 0.3.5.x-final priority::immediate resolution::implemented reviewer::teor rust severity::blocker sponsor::8 status::closed type::defect labels

Branch is nss_tls_protover, based on my nss_tls branch.

Trac:
Status: new to needs_review

This also looks fine to me. I'm assuming it will run on CI, so I don't actually need to run it.

I'm slightly disappointed that we now have 3 copies of the supported protocols string, where we used to have 2. But that's an issue for another ticket.

Trac:
Keywords: N/A deleted, rust added
Reviewer: N/A to teor
Status: needs_review to merge_ready

Trac:
Status: merge_ready to needs_review

nickm, I'm not sure what review work or other work needs to be done on this ticket.

Trac:
Status: needs_review to needs_revision

Oh! I think I mistook this for another ticket when I put it back in needs_review.

Trac:
Status: needs_revision to merge_ready

Update -- the code for authorities to no longer vote for LinkAuth=1 is merged (#27286 (moved)), but not enough authorities have upgraded yet. When they do, we can merge this.

Enough authorities are now voting not to include LinkAuth=1. I'll cherry-pick this commit to master.

Trac:
Status: merge_ready to closed
Resolution: N/A to implemented

Replying to nickm:

Enough authorities are now voting not to include LinkAuth=1. I'll cherry-pick this commit to master.

Please revert this change.

When loading the consensus from disk, Tor does the protocol check before we do the consensus expiry check: https://github.com/torproject/tor/blob/b67f3b751a277fb940b155c0bc64f594db5549b0/src/feature/nodelist/networkstatus.c#L1871

Therefore, any Tor that has an old cached consensus, and deploys this code, will restart in a loop without ever downloading a new consensus.

Thanks to traumschule for this bug report.

Trac:
Priority: Medium to Immediate
Status: closed to reopened
Resolution: implemented to N/A
Severity: Normal to Blocker

See #27731 (moved) for the bug report.

This issue affects NSS and OpenSSL tors on master, due to #27734 (moved).

chutney's mixed network logs a warning, but doesn't fail:

PASS: mixed+hs-v2
Detail: chutney/tools/warnings.sh /Users/base/chutney/net/nodes.1536899915
Warning: At least one protocol listed as recommended in the consensus is not supported by this version of Tor. You should upgrade. This version of Tor will eventually stop working as a client on the Tor network. The missing protocols are: LinkAuth=1 Number: 6
Warning: At least one protocol listed as recommended in the consensus is not supported by this version of Tor. You should upgrade. This version of Tor will eventually stop working as a relay on the Tor network. The missing protocols are: LinkAuth=1 Number: 27

New tors only fail in a network with a majority of old authorities. (And the network itself would only fail if it was a minimal network, and those new tors were essential to transmitting client data.)

unparenting.

Per discussion, I do not currently plan to revert this, but instead to include "how to try out NSS" instructions.

Trac:
Parent: #26631 (moved) to N/A

Trac:
Resolution: N/A to implemented
Status: reopened to closed

closed

mentioned in issue #27731 (moved)

mentioned in issue #27735 (moved)

moved to tpo/core/tor#27288 (closed)