Opened 4 weeks ago

Closed 5 days ago

#27289 closed defect (implemented)

Count raw bytes on the wire correctly when using NSS

Reported by: nickm Owned by: nickm
Priority: Low Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: #26631 Points:
Reviewer: Sponsor: Sponsor8-can

Description

Right now we don't support counting the raw bytes send over TCP with NSS, but it's possible. To do this, we'd need to use PRFileDesc's layering feature, and add a layer whose only purpose is to count bytes.

This change would make our bandwidth accounting slightly more accurate with NSS.

I think it would be safe to defer this.

Child Tickets

Change History (7)

comment:1 Changed 6 days ago by nickm

Owner: set to nickm
Status: newaccepted

comment:2 Changed 6 days ago by nickm

Status: acceptedneeds_review

Code in branch nss_countbytes, with PR at https://github.com/torproject/tor/pull/328

comment:3 Changed 6 days ago by ahf

Status: needs_reviewneeds_revision

Left some comments on the GH PR.

comment:4 Changed 5 days ago by nickm

Status: needs_revisionneeds_review

pushed some fixup commits. Better now?

comment:5 Changed 5 days ago by ahf

Status: needs_reviewmerge_ready

LGTM.

comment:6 Changed 5 days ago by nickm

squashed and merged!

comment:7 Changed 5 days ago by nickm

Resolution: implemented
Status: merge_readyclosed
Note: See TracTickets for help on using tickets.