Opened 2 months ago

Closed 8 weeks ago

#27295 closed defect (fixed)

make test-network-all should clear the test_network_log directory before running

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version: Tor: 0.2.7.3-rc
Severity: Normal Keywords: tor-test, chutney, 029-backport, 032-backport, 033-backport, 034-backport, fast-fix
Cc: Actual Points:
Parent ID: Points:
Reviewer: nickm Sponsor:

Description

If it doesn't, stale results in the directory can cause the build to fail.

Child Tickets

Change History (6)

comment:1 Changed 2 months ago by teor

Status: assignedneeds_review
Version: Tor: 0.2.7.3-rc

See my branch bug27295-029 on https://github.com/teor2345/tor.git

I'm testing it right now.

comment:2 Changed 2 months ago by teor

I tested this branch locally, and it removes stale test files.

comment:3 Changed 8 weeks ago by nickm

This looks okay to me, but it isn't against maint-0.2.9 -- in spite of its name, it's based on maint-0.3.4. Which branch did you want to merge it to?

comment:4 Changed 8 weeks ago by nickm

Reviewer: nickm

comment:5 in reply to:  3 Changed 8 weeks ago by teor

Replying to nickm:

This looks okay to me, but it isn't against maint-0.2.9 -- in spite of its name, it's based on maint-0.3.4. Which branch did you want to merge it to?

I'm sorry, I must have forgotten to do a rebase.

I rebased to maint-0.2.9 and force-pushed.

comment:6 Changed 8 weeks ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Thanks; merged this to 0.2.9 and forward!

Note: See TracTickets for help on using tickets.