Opened 8 months ago

Closed 8 months ago

#27332 closed defect (fixed)

outdated documentation for connection_handle_write_impl()

Reported by: cyberpunks Owned by:
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: doc
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

 * This function gets called either from conn_write_callback() in main.c
 * when libevent tells us that conn wants to write, or below
 * from connection_buf_add() when an entire TLS record is ready.

, or below ... when an entire TLS record is ready hasn't been accurate since d9746bd468f551d1ada57d962b20eddd15256ce9.

It and connection_handle_read_impl also don't mention only ever being called indirectly via connection_handle_write()/read since d3be00e0f454998db6387c8547d218a0db93db21, but that's more readily apparent at least.

Child Tickets

Change History (4)

comment:1 Changed 8 months ago by nickm

Milestone: Tor: unspecified

I'm happy to take a patch here.

comment:2 in reply to:  1 Changed 8 months ago by cyberpunks

See connection-comments1 branch at https://gitgud.io/onionk/tor.git

comment:3 Changed 8 months ago by teor

Milestone: Tor: unspecifiedTor: 0.3.5.x-final
Status: newneeds_review

comment:4 Changed 8 months ago by nickm

Resolution: fixed
Status: needs_reviewclosed

lgtm; merged to master!

Note: See TracTickets for help on using tickets.