#27390 closed defect (fixed)

Properly clean up sanitized web server logs in the recent/ directory

Reported by: karsten Owned by: metrics-team
Priority: Medium Milestone:
Component: Metrics/CollecTor Version:
Severity: Normal Keywords:
Cc: metrics-team Actual Points:
Parent ID: Points:
Reviewer: irl Sponsor:

Description

Looks like we forgot to properly implement the part where we clean up sanitized web server logs in the recent/ directory. They just pile up there and are not deleted when they turn older than three days. That's different from all other modules.

See CollecTor's index file which contains lots and lots of not-as-recent sanitized web server logs.

I'll post a branch in a minute. Let's put out a release with this fix within the next week or so.

Child Tickets

Change History (4)

comment:1 Changed 15 months ago by karsten

Status: newneeds_review

comment:2 Changed 14 months ago by irl

Reviewer: irl

Adding to the queue.

comment:3 Changed 14 months ago by irl

Status: needs_reviewmerge_ready

How much does the new function in PersistenceUtils differ from the similar functions:

onionperf/OnionPerfDownloader.java:  public void cleanUpRsyncDirectory() throws ConfigurationException {
exitlists/ExitListDownloader.java:  public void cleanUpRsyncDirectory() {
bridgedescs/SanitizedBridgesWriter.java:  public void cleanUpRsyncDirectory() throws ConfigurationException {
relaydescs/ArchiveWriter.java:  public void cleanUpRsyncDirectory() {

Currently webstats does seem to be the only module that uses the shared function. The relaydescs module may need something more complex to handle persisting microdescriptors for longer, but the other modules could maybe just switch? This could be a new ticket.

comment:4 Changed 13 months ago by karsten

Resolution: fixed
Status: merge_readyclosed

I'd like to separate the fix from the possible refactoring. I just created #28003 for the suggestion above and merged the patch to master. Closing. Thanks!

Note: See TracTickets for help on using tickets.