Opened 12 months ago

Closed 12 months ago

Last modified 9 months ago

#27398 closed defect (fixed)

Create GH/torproject/sbws repository

Reported by: juga Owned by: pastly
Priority: Medium Milestone: sbws: 1.0.x-final
Component: Core Tor/sbws Version:
Severity: Normal Keywords: sbws-1.0-must-closed-moved-20181128
Cc: pastly, juga, teor Actual Points:
Parent ID: Points:
Reviewer: teor Sponsor:

Description

As commented in network-team ml, we should create:

  • a repository called sbws in GH/torproject
  • give permissions to pastly, teor, juga to that repository
  • push current GH/pastly/simple-bw-scanner master to it
  • remove GH/torproject/simple-bw-scanner

When that is done, we can create other ticket to sync that repository with .git.tpo/sbws

Child Tickets

Change History (14)

comment:1 Changed 12 months ago by juga

We should probably archive our own GH clones so that other people do not clone or open issues on them.

comment:2 Changed 12 months ago by teor

Milestone: sbws 1.0 (MVP must)
Owner: set to teor
Status: newassigned

I can do this task.

comment:3 in reply to:  description ; Changed 12 months ago by teor

Owner: changed from teor to pastly

Replying to juga:

… we should create:

  • a repository called sbws in GH/torproject

Done!

  • give permissions to pastly, teor, juga to that repository

I have given the network team admin access.
I have invited pastly and juga into the sbws-admins group.

  • push current GH/pastly/simple-bw-scanner master to it

I think pastly or juga should do this when they're happy with the state of master.

  • remove GH/torproject/simple-bw-scanner

I can do this when we're happy with GH/torproject/sbws.

When that is done, we can create other ticket to sync that repository with .git.tpo/sbws.

I think pastly or juga should do this when they are happy with the state of git.tpo/sbws and GH/torproject/sbws.

I'm guessing that pastly knows more about the master branch, so the next step is his.

comment:4 in reply to:  3 Changed 12 months ago by juga

Replying to teor:

Replying to juga:

… we should create:

  • a repository called sbws in GH/torproject

Done!

thanks!
Hmm, if pastly would agree to change ownership from GH/pastly/simple-bw-scanner to GH/torproject/sbws, we won't need to migrate issues/PR, though GH/torproject/sbws should be deleted.

  • push current GH/pastly/simple-bw-scanner master to it

I think pastly or juga should do this when they're happy with the state of master.

if we continue main development in the master branch and tag/release only specific commits, master should be the same as it is now in /pastly, and i could push it myself.

I'm guessing that pastly knows more about the master branch, so the next step is his.

see above

comment:5 Changed 12 months ago by pastly

I've pushed the master branch to torproject/sbws on GH, but think juga's comment above is a good idea. To elaborate:

Let's use the transfer ownership functionality of GH. That way we can keep the existing issues and PRs.

  1. Teor should be able to delete torproject/sbws and torproject/simple-bw-scanner. Please do that.
  2. Once that's done, pastly can transfer ownership of pastly/simple-bw-scanner to torproject/simple-bw-scanner. This should maintain tickets/PRs.
  3. Once that's done, pastly/juga/teor can rename torproject/simple-bw-scanner to torproject/sbws
  4. Once that's done, someone can setup syncing of git.tpo/sbws with torproject/sbws

comment:6 Changed 12 months ago by juga

In the meanwhile i changed my mind and i thought it would be faster/cleaner if we don't transfer the repo.
But teor, pastly, go ahead with whatever is faster so i can continue making PRs or pushing my work.

comment:7 in reply to:  5 Changed 12 months ago by teor

Replying to pastly:

I've pushed the master branch to torproject/sbws on GH, but think juga's comment above is a good idea. To elaborate:

Let's use the transfer ownership functionality of GH. That way we can keep the existing issues and PRs.

And forks!

  1. Teor should be able to delete torproject/sbws and torproject/simple-bw-scanner. Please do that.

I deleted sbws, but I archived simple-bw-scanner to simple-bw-scanner-old. We can delete it when we're done.

  1. Once that's done, pastly can transfer ownership of pastly/simple-bw-scanner to torproject/simple-bw-scanner. This should maintain tickets/PRs.

You should probably delete your personal branches after the transfer.
If you want to preserve that history, you can re-push them to a new personal fork.

  1. Once that's done, pastly/juga/teor can rename torproject/simple-bw-scanner to torproject/sbws
  2. Once that's done, someone can setup syncing of git.tpo/sbws with torproject/sbws

comment:8 Changed 12 months ago by pastly

Failed at step 2. I can't transfer pastly/simple-bw-scanner to torproject because:

torproject already has a repository in the pastly/simple-bw-scanner network and You don’t have the permission to create repositories on torproject

I think the first problem would be solved by deleting torproject/simple-bw-scanner-old. I don't know if there is another way to solve it.

The second problem probably shouldn't be solved. I don't generally need permission to create repos in the torproject org.

So uhh... carry on how you see fit. Don't wait on me!

comment:9 in reply to:  8 Changed 12 months ago by teor

Replying to pastly:

Failed at step 2. I can't transfer pastly/simple-bw-scanner to torproject because:

torproject already has a repository in the pastly/simple-bw-scanner network

I think the first problem would be solved by deleting torproject/simple-bw-scanner-old. I don't know if there is another way to solve it.

I deleted the repository. It didn't have anything worth keeping.

You don’t have the permission to create repositories on torproject

The second problem probably shouldn't be solved. I don't generally need permission to create repos in the torproject org.

I have made you an owner so you can do the transfer. When you're done, I will make you a member again.

comment:10 Changed 12 months ago by pastly

Finished steps 2 and 3. Thanks Teor. I can have my permissions removed now.

comment:11 Changed 12 months ago by teor

I have removed pastly as an owner on torproject.

I added the sbws group as admins, and cleaned up all the old branches.

pastly, can you check we still need all the deploy keys at:
https://github.com/torproject/sbws/settings/keys

The syncing ticket is #27505.

Juga, you can now create pull requests on github.com/torproject/sbws, and push to git-rw.torproject.org/sbws.git

comment:12 Changed 12 months ago by teor

Resolution: fixed
Status: assignedclosed

comment:13 in reply to:  11 Changed 12 months ago by pastly

Replying to teor:

pastly, can you check we still need all the deploy keys at:
https://github.com/torproject/sbws/settings/keys

Removed them, they're unneeded.

comment:14 Changed 9 months ago by teor

Keywords: sbws-1.0-must-closed-moved-20181128 added
Milestone: sbws 1.0 (MVP must)sbws: 1.0.x-final

Move all closed sbws 1.0 must tickets to sbws 1.0.x-final

Note: See TracTickets for help on using tickets.