Opened 4 months ago

Closed 3 months ago

Last modified 8 weeks ago

#27400 closed enhancement (fixed)

Backport Bug 1473872 - Target API 26

Reported by: sysrqb Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, TorBrowserTeam201809R
Cc: igt0, gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor: Sponsor8

Description

We can't upload to Google Play until this is complete.

https://bugzilla.mozilla.org/show_bug.cgi?id=1473872

Your app currently targets API level 23 and must target at least API level 26
to ensure it is built on the latest APIs optimized for security and performance.
Change your app's target API level to at least 26.

We missed the cut-off for the <26 requirement:

Google Play will require that new apps target at least Android 8.0 (API level
26) from August 1, 2018, and that app updates target Android 8.0 from November
1, 2018.

https://developer.android.com/distribute/best-practices/develop/target-sdk

Child Tickets

Change History (5)

comment:1 Changed 3 months ago by sysrqb

Okay. This is more complicated than expected. Not only do we need to backport the commit from Bug 1473872, but we need Bug 1352015 and (part of) Bug 1444546. The largest complication is Bug 1444546 changes part of the build system, and I prefer not backporting a large patch if we don't absolutely need it right now.

comment:2 Changed 3 months ago by sysrqb

Status: newneeds_review

Okay. After many hours of working on backporting the upstream patches, I decided I'd try simply increasing the target API version. I reviewed the upstream patches and I don't see any logical run-time changes, from what I see the upstream patches are all build-time (and build system) changes. Therefore, I don't believe this patch should cause any run-time problems. I've tested this, and I don't see any noticeable difference on older and newer API versions.

Specifically, the upstream patches changed the linting system, and annotation processing. I'm relatively certain we can continue using the current system for now.

Branch for review: 27400_2.

comment:3 Changed 3 months ago by igt0

Status: needs_reviewmerge_ready

It looks good, I tested in a API 23 and 26 device and I also didn't see any runtime issue.

comment:4 Changed 3 months ago by gk

Keywords: TorBrowserTeam201809R added
Resolution: fixed
Status: merge_readyclosed

Thanks, that got cherry-picked to tor-browser-60.2.0esr-8.5-1 as commit 641dea421ec41553993b92d79a98394ae541f476.

comment:5 Changed 8 weeks ago by pili

Sponsor: Sponsor8
Note: See TracTickets for help on using tickets.