Opened 4 months ago

Closed 4 months ago

Last modified 4 months ago

#27401 closed defect (fixed)

RC for Tor Browser 8.0 disables JavaScript on first start and does not load onboarding

Reported by: gk Owned by: tbb-team
Priority: Immediate Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201808R, AffectsTails
Cc: arthuredelstein, ma1, mcs, brade, boklm, rustybird, intrigeri Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

#26520 fixed some race condition between Torbutton and NoScript leading to JavaScript being disabled on first session.

It seems we hit something that looks similar with our RC for Tor Browser 8 (see: https://people.torproject.org/~boklm/builds/8.0-build2/). However, this happens in a default Tor Browser on Linux: On first start JavaScript is disabled even though the security slider is set to default.

Moreover our onboarding does not show up either.

Child Tickets

Change History (6)

comment:1 Changed 4 months ago by gk

The first nightly that breaks is the one from 08/30. The one we still have from 08/27 is fine. That's both with NoScript 10.8.1.16.

I wonder whether the onboarding broke things here (random guess)...

comment:2 Changed 4 months ago by arthuredelstein

Keywords: TorBrowserTeam201808R added; TorBrowserTeam201808 removed
Status: newneeds_review

The NoScriptControl wasn't listening early enough to receive NoScript's "started" message. Here's a patch for review that fixes that:

https://github.com/arthuredelstein/torbutton/commit/27401

comment:3 Changed 4 months ago by gk

Cc: rustybird intrigeri added
Resolution: fixed
Status: needs_reviewclosed

Thanks, this looks good and actually makes sense re-reading Giorgio's comment:39:ticket:26520. Moving the onboarding issue to a different bug (#27403) as this is not solved by this patch yet.

Merged to master with commit 9b79f00ade001b7da59ef0c8c6f560a62da954bb.

comment:4 Changed 4 months ago by intrigeri

gk, is this fix included in your 8.0-build4? I'd like to check tomorrow how we're doing on Tails with the current Tor Browser RC.

comment:5 in reply to:  4 Changed 4 months ago by gk

Replying to intrigeri:

gk, is this fix included in your 8.0-build4? I'd like to check tomorrow how we're doing on Tails with the current Tor Browser RC.

It is. And it is in -build5 which I am currently uploading and will hopefully be the last RC. So, I'd suggest taking that one instead.

comment:6 Changed 4 months ago by gk

Keywords: AffectsTails added
Note: See TracTickets for help on using tickets.