Opened 12 months ago

Last modified 9 months ago

#27408 new task

Make it possible to find which tor-browser-build.git commit was used to build a nightly

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201809, boklm201811
Cc: arthuredelstein Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Currently it is possible to look at the nightly build logs to find which tor-browser.git or tor.git commit was used in a nightly build. However the logs don't include the tor-browser-build.git commit.

We should make it possible to find which tor-browser-build.git commit was used to build a nightly build.

Child Tickets

Change History (3)

comment:1 Changed 12 months ago by arthuredelstein

Cc: arthuredelstein added

Thanks for filing this ticket! It would also be nice if the nightly build package filename itself included the commit hash from tor-browser-build.git.

comment:2 in reply to:  1 Changed 12 months ago by boklm

Replying to arthuredelstein:

Thanks for filing this ticket! It would also be nice if the nightly build package filename itself included the commit hash from tor-browser-build.git.

I think adding the tor-browser-build.git commit in the filename in projects/tor-browser/config would force us to re-bundle tor browser when it's not needed:

  • sometimes we make commits that affect only one platform
  • sometimes we make commits that don't affect the builds at all (for instance files in the tools/update-responses/ directory)

But we could add a tor-browser-build-commit.txt file in the final directory. I started doing that in branch bug_27408 (but did not test it yet):
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_27408&id=940bbc592ec232e85f3783f2ef26be1b388faf0b

comment:3 Changed 9 months ago by boklm

Keywords: boklm201811 added; boklm201809 removed

boklm201809 -> boklm201811

Note: See TracTickets for help on using tickets.