Opened 15 months ago
Closed 15 months ago
#27428 closed defect (implemented)
require ContactInfo line to be UTF-8
Reported by: | cyberpunks | Owned by: | |
---|---|---|---|
Priority: | Medium | Milestone: | Tor: 0.3.5.x-final |
Component: | Core Tor/Tor | Version: | |
Severity: | Normal | Keywords: | rust-wants, prop285 |
Cc: | teor | Actual Points: | |
Parent ID: | #27380 | Points: | |
Reviewer: | teor | Sponsor: |
Description
Child Tickets
Change History (8)
comment:1 Changed 15 months ago by
comment:2 Changed 15 months ago by
Status: | new → needs_review |
---|
comment:3 Changed 15 months ago by
Reviewer: | → teor |
---|
This looks good to me. teor, can you confirm that your "merge_ready" on #27373 applies here too?
comment:4 Changed 15 months ago by
Status: | needs_review → merge_ready |
---|
This patch looks good to me.
It's ok to start warning on relays, before authorities start rejecting descriptors.
Eventually, we should add UTF-8 and invalid ContactInfos to test_options.c. I opened #27645 for these tests.
comment:5 follow-up: 6 Changed 15 months ago by
I opened a pull request, so that appveyor CI runs properly on this branch:
https://github.com/torproject/tor/pull/318
comment:6 Changed 15 months ago by
protover/vote:
FAIL src/test/test_protover.c:175: assert(result OP_EQ ""): <Bar=2> vs <>
[vote FAILED]
1/1145 TESTS FAILED. (11 skipped)
The test from #27205 is failing on --enable-rust
CI builds apparently?
comment:8 Changed 15 months ago by
Resolution: | → implemented |
---|---|
Status: | merge_ready → closed |
per teor, this change for the 0.3.5 LTS is in the unicode-contactinfo1 branch at https://gitgud.io/onionk/tor.git