Opened 8 years ago

Last modified 14 months ago

#2743 assigned defect

safelogging should cover hidden service name and intro-points too

Reported by: arma Owned by: rransom
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs intro
Cc: Actual Points:
Parent ID: Points: 5
Reviewer: Sponsor:

Description

In log messages about a hidden service we operate, we don't replace the hidden service name with [scrubbed].

Historically, this was considered fine, because you have your hostname and private_key files on disk already.

But if the user puts his $datadir on encrypted storage, and the logs aren't on encrypted storage, then the logs could be the weak link.

Child Tickets

Change History (15)

comment:1 Changed 8 years ago by arma

Right now SafeLogging is a tristate -- 0, 1, or relay. "relay" is like 0 with respect to client messages but like 1 with respect to messages about other peoples' traffic.

I think messages about a hidden service you operate should count as client messages, whereas messages about somebody else's hidden service should count as relay messages. (We could make it a quadstate, but I don't think that's needed.)

comment:2 Changed 8 years ago by rransom

Owner: set to rransom
Status: newassigned

comment:3 Changed 8 years ago by rransom

A hidden service's introduction points should also be scrubbed.

This task should wait at least until #3045 is done.

comment:4 Changed 7 years ago by nickm

Milestone: Tor: 0.2.3.x-finalTor: 0.2.4.x-final

comment:5 Changed 7 years ago by StrangeCharm

Cc: StrangeCharm added

comment:6 Changed 7 years ago by nickm

Keywords: tor-hs added

comment:7 Changed 7 years ago by nickm

Component: Tor Hidden ServicesTor

comment:8 Changed 6 years ago by nickm

Milestone: Tor: 0.2.4.x-finalTor: 0.2.5.x-final
Summary: safelogging should cover hidden service operation toosafelogging should cover hidden service name and intro-points too

comment:9 Changed 5 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.???

comment:10 Changed 3 years ago by dgoulet

Points: medium
Severity: Normal

comment:11 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:12 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:13 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:14 Changed 2 years ago by nickm

Keywords: intro added
Points: medium5

comment:15 Changed 14 months ago by StrangeCharm

Cc: StrangeCharm removed
Note: See TracTickets for help on using tickets.