safelogging should cover hidden service name and intro-points too

In log messages about a hidden service we operate, we don't replace the hidden service name with [scrubbed].

Historically, this was considered fine, because you have your hostname and private_key files on disk already.

But if the user puts his $datadir on encrypted storage, and the logs aren't on encrypted storage, then the logs could be the weak link.

changed milestone to %Tor: unspecified

added component::core tor/tor intro milestone::Tor: unspecified owner::rransom points::5 priority::medium severity::normal status::assigned tor-hs type::defect labels

Right now SafeLogging is a tristate -- 0, 1, or relay. "relay" is like 0 with respect to client messages but like 1 with respect to messages about other peoples' traffic.

I think messages about a hidden service you operate should count as client messages, whereas messages about somebody else's hidden service should count as relay messages. (We could make it a quadstate, but I don't think that's needed.)

Trac:
Status: new to assigned
Owner: N/A to rransom

A hidden service's introduction points should also be scrubbed.

This task should wait at least until #3045 (moved) is done.

Trac:
Milestone: Tor: 0.2.3.x-final to Tor: 0.2.4.x-final

Trac:
Cc: N/A to StrangeCharm

Trac:
Keywords: N/A deleted, tor-hs added

Trac:
Component: Tor Hidden Services to Tor

Trac:
Milestone: Tor: 0.2.4.x-final to Tor: 0.2.5.x-final
Summary: safelogging should cover hidden service operation too to safelogging should cover hidden service name and intro-points too

Trac:
Milestone: Tor: 0.2.5.x-final to Tor: 0.2.???

Trac:
Sponsor: N/A to N/A
Severity: N/A to Normal
Reviewer: N/A to N/A
Points: N/A to medium

Milestone renamed

Trac:
Milestone: Tor: 0.2.??? to Tor: 0.3.???

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

Trac:
Keywords: N/A deleted, tor-03-unspecified-201612 added
Milestone: Tor: 0.3.??? to Tor: unspecified

Remove an old triaging keyword.

Trac:
Keywords: tor-03-unspecified-201612 deleted, N/A added

Trac:
Keywords: tor-hs deleted, tor-hs intro added
Points: medium to 5

Trac:
Cc: StrangeCharm to N/A

changed time estimate to 40h

moved to tpo/core/tor#2743