Configure Rust compiler to target Android Platform

Configure Rust compiler to target Android Platform

added TorBrowserTeam201810R component::applications/tor browser owner::tbb-team parent::26693 priority::medium resolution::fixed severity::normal sponsor::8 status::closed tbb-mobile tbb-rbm type::defect labels

Have a patch to address the page size not working due to !#27441 (moved): Update Debian Image to use Stretch

commit: https://github.com/sisbell/tor-browser-build/commit/2b5fa20f153d6ce708ab9043f2a5254f66ea9d7e

Trac:
Keywords: TorBrowserTeam201808 deleted, TorBrowserTeam201809R added
Status: new to needs_review

Replying to sisbell:

commit: https://github.com/sisbell/tor-browser-build/commit/2b5fa20f153d6ce708ab9043f2a5254f66ea9d7e

Some comments:

• instead of defining prev_rust twice (for android, and for other platforms), it is possible to define a variable var/rust_arch which defaults to var/arch, except on android where we set it to x86_64. The var/rust_arch variable can then be used in the prev_rust url, and the directory name in rust/build.
• android-toolchain should not need to be listed in the dependencies, if it is set as var/compiler (after the change is done in #26696 (moved)), as var/compiler is already listed in the dependencies.
• the setup of the android toolchain should not be done in projects/rust/build, but in var/setup defined in project/android-toolchain/config.

Trac:
Keywords: TorBrowserTeam201809R deleted, TorBrowserTeam201809 added
Status: needs_review to needs_revision

Moving tickets to October

Trac:
Keywords: TorBrowserTeam201809 deleted, TorBrowserTeam201810 added

I made the following changes:

• use '/var_rust_arch' value.
• no longer list android_toolchain as a dependency
• setup is done in android_toolchain

https://github.com/sisbell/tor-browser-build/commit/e12915862d1c4c30f47aaeae5c128927682267ad

Trac:
Status: needs_revision to needs_review
Keywords: TorBrowserTeam201810 deleted, TorBrowserTeam201810R added

Could you explain what the android.patch patch is doing, and why it is needed (for example, the error message we get without the patch)? Is it a patch we should try to get merged upstream?

Trac:
Status: needs_review to needs_revision
Keywords: TorBrowserTeam201810R deleted, TorBrowserTeam201810 added

Replying to boklm:

Could you explain what the android.patch patch is doing, and why it is needed (for example, the error message we get without the patch)? Is it a patch we should try to get merged upstream?

dl_iterate_phdr doesn't exist on debian stretch, so we are just creating dummy version everytime. getpagesize() is also not supported on debian stretch so we are using sysconf(_SC_PAGESIZE), which is supported

I confirmed that we can remove this patch with the latest code now that the build is using the Android NDK for building.

I looked at commit 2d5d46f20356e7fd40fd28ceacc7512905eceb84. Could you remove the whitespace on the line after configure_opt?

change (android-1024)

• Removed white space after configure_opt
• Removed x86_64-unknown-linux-gnu as target (this is not needed)

Trac:
Status: needs_revision to needs_review

In commit 992b9324097f41c9503eb4ada393cec3da03195c, the patch is removing the empty line before targets:, but I think we should keep it as it separates the different parts of the file. Other than this it looks good to me.

Trac:
Status: needs_review to needs_revision

Replying to boklm:

In commit 992b9324097f41c9503eb4ada393cec3da03195c, the patch is removing the empty line before targets:, but I think we should keep it as it separates the different parts of the file. Other than this it looks good to me.

I added extra line

Looks good. Please use a new branch for fixups. That makes reviewing easier, thanks. Cherry-picked to master (commit 61cdddfa4b7daf96f6bd1a52fb25a3ec055cc401).

Trac:
Keywords: TorBrowserTeam201810 deleted, TorBrowserTeam201810R added
Status: needs_revision to closed
Resolution: N/A to fixed

More Sponsor8 items.

Trac:
Sponsor: N/A to Sponsor8

closed

moved to tpo/applications/tor-browser#27439 (closed)