Update Debian Image to use Stretch

Update the build image to use debian stretch

added TorBrowserTeam201810R component::applications/tor browser owner::tbb-team parent::26693 priority::high resolution::fixed severity::normal sponsor::8 status::closed tbb-mobile tbb-rbm type::task labels

Also see #26976 (moved) Hardening Wrapper Removed in Debian Stretch

Commit: !https://github.com/sisbell/tor-browser-build/commit/24fc2e3d63ec6fd692b1b405bd2cdaec0f5c4adb

Trac:
Status: new to needs_review
Keywords: TorBrowserTeam201808 deleted, TorBrowserTeam201809R added
Type: defect to task

Replying to sisbell:

Commit: !https://github.com/sisbell/tor-browser-build/commit/24fc2e3d63ec6fd692b1b405bd2cdaec0f5c4adb

Some comments about this patch:

• subject of the commit should be in the format "Bug XXX: description"
• maybe something like "add support for stretch in debootstrap-image" is more clear than "Update Debian Image to use Stretch"
• it seems there is a 18.04.1 ubuntu release, so maybe we should use that instead of 18.04.

Otherwise this looks good. Before merging this we should also check that changing the ubuntu version does not break generation of the other debian images (for instance by trying to do a full build of Tor Browser for Windows/Linux/macOS with this patch).

Trac:
Status: needs_review to needs_revision
Keywords: TorBrowserTeam201809R deleted, TorBrowserTeam201809 added

Added 18.04.1 version to config. This still needs to be tested to make sure it doesn't break anything. I'll do testing this week.

Moving tickets to October

Trac:
Keywords: TorBrowserTeam201809 deleted, TorBrowserTeam201810 added

Commit 9f90042f71ec8d509c7beb5e9efeb97a8390aa3a looks good. I think it can be merged, once it has been checked that it doesn't break generation of other images.

Setting priority to High, as this is the first commit we need to merge before being able to merge the others.

Trac:
Priority: Medium to High
Status: needs_revision to needs_review

Trac:
Keywords: TorBrowserTeam201810 deleted, TorBrowserTeam201810R added

One nit: This contains a trailing whitespace after the sha256 sum. Please remove it.

Okay, this works for me I think. Just the nit in comment:9 and we can merge this part.

Trac:
Keywords: TorBrowserTeam201810R deleted, TorBrowserTeam201810 added
Status: needs_review to needs_revision

Removed trailing white space: https://github.com/sisbell/tor-browser-build/commits/android-1017

Replying to sisbell:

Removed trailing white space: https://github.com/sisbell/tor-browser-build/commits/android-1017

In commit 9f90042f71ec8d509c7beb5e9efeb97a8390aa3a from the android-1017 branch, I still see a trailing white space after the sha256sum. Actually the commit is the same in the android-rebased and the android-1017 branch.

Replying to boklm:

Replying to sisbell:

Removed trailing white space: https://github.com/sisbell/tor-browser-build/commits/android-1017

In commit 9f90042f71ec8d509c7beb5e9efeb97a8390aa3a from the android-1017 branch, I still see a trailing white space after the sha256sum. Actually the commit is the same in the android-rebased and the android-1017 branch.

Fixed, try now

In commit 7d14d1b96aaf5c5718fdf9ed6ad8986abfa6902d the trailing white space is removed, but now there is a typo: ha256sum instead of sha256sum.

Fixed

Commit 95ddadc04cd34315c91348a78cb928672e19cee4 looks good to me. I think we can merge it after we know we won't need to do rebuilds for 8.5a4.

Trac:
Status: needs_revision to needs_review
Keywords: TorBrowserTeam201810 deleted, TorBrowserTeam201810R added

Applied to master (commit 5cd65aaa478a41bd8c98a5405a5bf5b82256ca67). Yay!

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

More Sponsor8 items.

Trac:
Sponsor: N/A to Sponsor8

closed

moved to tpo/applications/tor-browser#27441 (closed)