Opened 14 months ago

Closed 12 months ago

Last modified 10 months ago

#27441 closed task (fixed)

Update Debian Image to use Stretch

Reported by: sisbell Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, tbb-mobile, TorBrowserTeam201810R
Cc: sisbell Actual Points:
Parent ID: #26693 Points:
Reviewer: Sponsor: Sponsor8

Description

Update the build image to use debian stretch

Child Tickets

Change History (19)

comment:1 Changed 14 months ago by sisbell

Also see #26976 Hardening Wrapper Removed in Debian Stretch

comment:2 Changed 14 months ago by sisbell

Commit: https://github.com/sisbell/tor-browser-build/commit/24fc2e3d63ec6fd692b1b405bd2cdaec0f5c4adb

comment:3 Changed 14 months ago by boklm

Keywords: TorBrowserTeam201809R added; TorBrowserTeam201808 removed
Status: newneeds_review
Type: defecttask

comment:4 in reply to:  2 Changed 14 months ago by boklm

Keywords: TorBrowserTeam201809 added; TorBrowserTeam201809R removed
Status: needs_reviewneeds_revision

Replying to sisbell:

Commit: https://github.com/sisbell/tor-browser-build/commit/24fc2e3d63ec6fd692b1b405bd2cdaec0f5c4adb

Some comments about this patch:

  • subject of the commit should be in the format "Bug XXX: description"
  • maybe something like "add support for stretch in debootstrap-image" is more clear than "Update Debian Image to use Stretch"
  • it seems there is a 18.04.1 ubuntu release, so maybe we should use that instead of 18.04.

Otherwise this looks good. Before merging this we should also check that changing the ubuntu version does not break generation of the other debian images (for instance by trying to do a full build of Tor Browser for Windows/Linux/macOS with this patch).

comment:5 Changed 13 months ago by sisbell

Added 18.04.1 version to config. This still needs to be tested to make sure it doesn't break anything. I'll do testing this week.

comment:6 Changed 13 months ago by gk

Keywords: TorBrowserTeam201810 added; TorBrowserTeam201809 removed

Moving tickets to October

comment:7 Changed 12 months ago by boklm

Priority: MediumHigh
Status: needs_revisionneeds_review

Commit 9f90042f71ec8d509c7beb5e9efeb97a8390aa3a looks good. I think it can be merged, once it has been checked that it doesn't break generation of other images.

Setting priority to High, as this is the first commit we need to merge before being able to merge the others.

comment:8 Changed 12 months ago by gk

Keywords: TorBrowserTeam201810R added; TorBrowserTeam201810 removed

comment:9 Changed 12 months ago by gk

One nit: This contains a trailing whitespace after the sha256 sum. Please remove it.

comment:10 Changed 12 months ago by gk

Okay, this works for me I think. Just the nit in comment:9 and we can merge this part.

comment:11 Changed 12 months ago by gk

Keywords: TorBrowserTeam201810 added; TorBrowserTeam201810R removed
Status: needs_reviewneeds_revision

comment:12 Changed 12 months ago by sisbell

comment:13 in reply to:  12 ; Changed 12 months ago by boklm

Replying to sisbell:

Removed trailing white space: https://github.com/sisbell/tor-browser-build/commits/android-1017

In commit 9f90042f71ec8d509c7beb5e9efeb97a8390aa3a from the android-1017 branch, I still see a trailing white space after the sha256sum. Actually the commit is the same in the android-rebased and the android-1017 branch.

comment:14 in reply to:  13 Changed 12 months ago by sisbell

Replying to boklm:

Replying to sisbell:

Removed trailing white space: https://github.com/sisbell/tor-browser-build/commits/android-1017

In commit 9f90042f71ec8d509c7beb5e9efeb97a8390aa3a from the android-1017 branch, I still see a trailing white space after the sha256sum. Actually the commit is the same in the android-rebased and the android-1017 branch.

Fixed, try now

comment:15 Changed 12 months ago by boklm

In commit 7d14d1b96aaf5c5718fdf9ed6ad8986abfa6902d the trailing white space is removed, but now there is a typo: ha256sum instead of sha256sum.

comment:16 Changed 12 months ago by sisbell

Fixed

comment:17 Changed 12 months ago by boklm

Keywords: TorBrowserTeam201810R added; TorBrowserTeam201810 removed
Status: needs_revisionneeds_review

Commit 95ddadc04cd34315c91348a78cb928672e19cee4 looks good to me. I think we can merge it after we know we won't need to do rebuilds for 8.5a4.

comment:18 Changed 12 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Applied to master (commit 5cd65aaa478a41bd8c98a5405a5bf5b82256ca67). Yay!

comment:19 Changed 10 months ago by gk

Sponsor: Sponsor8

More Sponsor8 items.

Note: See TracTickets for help on using tickets.