Opened 2 weeks ago

Closed 2 weeks ago

#27472 closed enhancement (fixed)

TBA: Add export MOZILLA_OFFICIAL

Reported by: sysrqb Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile
Cc: gk, igt0 Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

.mozconfig-android currently contains mk_add_options MOZILLA_OFFICIAL=1, but this doesn't enable all needed "MOZILLA_OFFICIAL" build-time options. Adding export MOZILLA_OFFICIAL=1 seems like it accomplishes this.

Child Tickets

Change History (5)

comment:1 Changed 2 weeks ago by sysrqb

Component: - Select a componentApplications/Tor Browser
Owner: set to tbb-team

comment:2 Changed 2 weeks ago by sysrqb

Status: newneeds_review

Please review 27472 in my user repo.

comment:3 Changed 2 weeks ago by sysrqb

Cc: gk igt0 added
Keywords: tbb-mobile added

comment:4 Changed 2 weeks ago by igt0

Status: needs_reviewmerge_ready

You are right, without the patch the MOZILLA_OFFICIAL was not being set. Besides testing on my device, I also looked in the mozilla repo[1] and the patch makes totally sense.

[1] https://dxr.mozilla.org/mozilla-central/search?q=MOZILLA_OFFICIAL&redirect=false

comment:5 Changed 2 weeks ago by gk

Resolution: fixed
Status: merge_readyclosed

Cherry-picked to tor-browser-60.2.0esr-8.5-1 (commit bd090e4ef466374ca3c231efa350159f7c0ab96c), thanks!

Note: See TracTickets for help on using tickets.