Opened 3 months ago

Closed 3 months ago

#27478 closed defect (fixed)

Torbutton in Tor Browser 8 difficult to see in dark theme

Reported by: nsuchy Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ux-team, tbb-8.0-issues, tbb-8.0.1-can, TorBrowserTeam201809R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Tor Browser 8 includes Firefox ESR 60's "dark theme". It looks quite nice and I elected to enable it. The Torbutton (used for security, and tor network settings) is difficult to see in contrast to other icons. In dark mode it'd be nice to enable a light grey version of it. Thoughts?

Child Tickets

Attachments (3)

Screen Shot 2018-09-05 at 2.22.06 PM.png (128.2 KB) - added by nsuchy 3 months ago.
dark-theme.zip (23.0 KB) - added by antonela 3 months ago.
dark_theme_torbutton_27478.png (37.3 KB) - added by arthuredelstein 3 months ago.

Download all attachments as: .zip

Change History (9)

Changed 3 months ago by nsuchy

comment:1 Changed 3 months ago by gk

Keywords: ux-team tbb-8.0-issues added

Changed 3 months ago by antonela

Attachment: dark-theme.zip added

comment:2 Changed 3 months ago by antonela

hi! a dark-theme lover here!

I'm following Photon guidelines and attaching the .png for the Tor Button Icon ready to be implemented for the dark theme.

https://design.firefox.com/photon/visuals/color.html#dark-theme

Assets available here
https://trac.torproject.org/projects/tor/attachment/ticket/27478/dark-theme.zip

comment:3 Changed 3 months ago by gk

Keywords: tbb-8.0.1-can added

Marking for 8.0.1 can.

Changed 3 months ago by arthuredelstein

comment:4 Changed 3 months ago by arthuredelstein

Keywords: TorBrowserTeam201809R added

Here's a patch for review:

https://github.com/arthuredelstein/torbutton/commit/27478

And a screenshot:

comment:5 Changed 3 months ago by arthuredelstein

Status: newneeds_review

comment:6 Changed 3 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good to me, thanks! Cherry-picked to master (commit 9156c5564a5da6bd8e17eab094d655034e4135b6).

Note: See TracTickets for help on using tickets.