Opened 6 months ago
Closed 5 months ago
#27478 closed defect (fixed)
Torbutton in Tor Browser 8 difficult to see in dark theme
| Reported by: | nsuchy | Owned by: | tbb-team |
|---|---|---|---|
| Priority: | Medium | Milestone: | |
| Component: | Applications/Tor Browser | Version: | |
| Severity: | Normal | Keywords: | ux-team, tbb-8.0-issues, tbb-8.0.1-can, TorBrowserTeam201809R |
| Cc: | Actual Points: | ||
| Parent ID: | Points: | ||
| Reviewer: | Sponsor: |
Description
Tor Browser 8 includes Firefox ESR 60's "dark theme". It looks quite nice and I elected to enable it. The Torbutton (used for security, and tor network settings) is difficult to see in contrast to other icons. In dark mode it'd be nice to enable a light grey version of it. Thoughts?
Child Tickets
Attachments (3)
Change History (9)
Changed 6 months ago by
| Attachment: | Screen Shot 2018-09-05 at 2.22.06 PM.png added |
|---|
comment:1 Changed 6 months ago by
| Keywords: | ux-team tbb-8.0-issues added |
|---|
Changed 5 months ago by
| Attachment: | dark-theme.zip added |
|---|
comment:2 Changed 5 months ago by
Changed 5 months ago by
| Attachment: | dark_theme_torbutton_27478.png added |
|---|
comment:4 Changed 5 months ago by
| Keywords: | TorBrowserTeam201809R added |
|---|
Here's a patch for review:
https://github.com/arthuredelstein/torbutton/commit/27478
And a screenshot:
comment:5 Changed 5 months ago by
| Status: | new → needs_review |
|---|
comment:6 Changed 5 months ago by
| Resolution: | → fixed |
|---|---|
| Status: | needs_review → closed |
Looks good to me, thanks! Cherry-picked to master (commit 9156c5564a5da6bd8e17eab094d655034e4135b6).
Note: See
TracTickets for help on using
tickets.
hi! a dark-theme lover here!
I'm following Photon guidelines and attaching the .png for the Tor Button Icon ready to be implemented for the dark theme.
https://design.firefox.com/photon/visuals/color.html#dark-theme
Assets available here
https://trac.torproject.org/projects/tor/attachment/ticket/27478/dark-theme.zip