Torbutton in Tor Browser 8 difficult to see in dark theme

Tor Browser 8 includes Firefox ESR 60's "dark theme". It looks quite nice and I elected to enable it. The Torbutton (used for security, and tor network settings) is difficult to see in contrast to other icons. In dark mode it'd be nice to enable a light grey version of it. Thoughts?

Trac:
Username: nsuchy

added TorBrowserTeam201903R component::applications/tor browser owner::pospeselr parent::25658 priority::medium reporter::nsuchy resolution::fixed severity::normal status::closed tbb-8.0-issues tbb-8.0.1-can tbb-8.5 type::defect ux-team labels

Trac:
Username: nsuchy

Trac:
Username: nsuchy

Trac:
Keywords: N/A deleted, ux-team, tbb-8.0-issues added

Trac:
dark-theme.zip

hi! a dark-theme lover here!

I'm following Photon guidelines and attaching the .png for the Tor Button Icon ready to be implemented for the dark theme.

https://design.firefox.com/photon/visuals/color.html#dark-theme

Assets available here https://trac.torproject.org/projects/tor/attachment/ticket/27478/dark-theme.zip

Marking for 8.0.1 can.

Trac:
Keywords: N/A deleted, tbb-8.0.1-can added

Trac:

Here's a patch for review:

https://github.com/arthuredelstein/torbutton/commit/27478

And a screenshot:

Trac:
Keywords: N/A deleted, TorBrowserTeam201809R added

Trac:
Status: new to needs_review

Looks good to me, thanks! Cherry-picked to master (commit 9156c5564a5da6bd8e17eab094d655034e4135b6).

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

The color isn't quite right here with custom themes. As part of my work for #25658 (moved) figured out how firefox propagates the theme color to icons. In the source svg we need to set the fill to 'context-fill' and opacity to 'context-fill-opacity' and then the icon will get whatever colors are appropriate for the current theme.

Trac:
Status: closed to reopened
Resolution: fixed to N/A

Trac:
Owner: tbb-team to pospeselr
Status: reopened to assigned

Trac:
Cc: N/A to tbb-team
Keywords: TorBrowserTeam201809R deleted, TorBrowserTeam201903 added

Tickets on our radar for 8.5

Trac:
Keywords: N/A deleted, tbb-8.5 added

Trac:
Parent: N/A to #25658 (moved)

Trac:

Trac:

Trac:

Excised the torbutton svg changes from #25658 (moved) into this branch : https://gitweb.torproject.org/user/richard/torbutton.git/commit/?h=bug_27478

Torbutton icon now takes on appropriate fill and opacity values from the current theme.

Light Theme: Default Theme: Dark Theme:

Trac:
Keywords: TorBrowserTeam201903 deleted, TorBrowserTeam201903R added
Status: assigned to needs_review

Looks good, thanks! Merged to master (commit 2930d898032e04443527af8c6528481f202a2c4e).

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

moved to tpo/applications/tor-browser#27478 (closed)