Onboarding: "Visit an Onion" creates an "about:blank" loading page

Such a loading page can make a user unsure what's going on.

In contrast, the "See My Path" button does not do this (i.e. it shows the URL). (So it seems possible to fix this.)

(Encountered in TB 8.0)

added TorBrowserTeam201903R component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::minor status::closed tbb-8.0-issues tbb-8.0.1-can tbb-onboarding type::defect ux-team labels

Trac:
Keywords: ff60-esr deleted, tbb-onboarding, tbb-8.0-issues added

I think the difference in behavior occurs because there is special handling in the onboarding code for "See My Path" while "Visit an Onion" simply uses <a href="...onion" target="_blank".

Trac:
Keywords: N/A deleted, tbb-8.0.1-can added

Here is a patch: https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug27486-01&id=86581f52952e4cb2480a161ae91d62d60f37da1a

From the commit message: Instead of using a simple , programmatically open onboarding web pages by using tabBrowser.addTab(). The same technique is now used for "See My Path", "See FAQs", and "Visit an Onion".

Trac:
Keywords: N/A deleted, TorBrowserTeam201902R added
Status: new to needs_review

February is gone.

Trac:
Keywords: TorBrowserTeam201902R deleted, TorBrowserTeam201903R added

Looks good to me. Cherry-picked onto tor-browser-60.5.1esr-8.5-1 (commit 3a69f6697799d7c6d0ed408df8aa28239b430556).

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

mentioned in issue #28628 (moved)

moved to tpo/applications/tor-browser#27486 (closed)