Opened 11 months ago

Closed 5 months ago

#27486 closed defect (fixed)

Onboarding: "Visit an Onion" creates an "about:blank" loading page

Reported by: dmr Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Minor Keywords: tbb-8.0-issues, tbb-onboarding, ux-team, tbb-8.0.1-can, TorBrowserTeam201903R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Such a loading page can make a user unsure what's going on.

In contrast, the "See My Path" button does not do this (i.e. it shows the URL).
(So it seems possible to fix this.)

(Encountered in TB 8.0)

Child Tickets

Change History (6)

comment:1 Changed 11 months ago by gk

Keywords: tbb-8.0-issues tbb-onboarding added; ff60-esr removed

comment:2 Changed 11 months ago by mcs

I think the difference in behavior occurs because there is special handling in the onboarding code for "See My Path" while "Visit an Onion" simply uses <a href="...onion" target="_blank".

comment:3 Changed 10 months ago by gk

Keywords: tbb-8.0.1-can added

comment:4 Changed 5 months ago by mcs

Keywords: TorBrowserTeam201902R added
Status: newneeds_review

Here is a patch:
https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug27486-01&id=86581f52952e4cb2480a161ae91d62d60f37da1a

From the commit message:

Instead of using a simple <a href>, programmatically open onboarding web pages by using tabBrowser.addTab(). The same technique is now used for "See My Path", "See FAQs", and "Visit an Onion".

comment:5 Changed 5 months ago by gk

Keywords: TorBrowserTeam201903R added; TorBrowserTeam201902R removed

February is gone.

comment:6 Changed 5 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good to me. Cherry-picked onto tor-browser-60.5.1esr-8.5-1 (commit 3a69f6697799d7c6d0ed408df8aa28239b430556).

Note: See TracTickets for help on using tickets.