Opened 9 months ago

Last modified 8 months ago

#27493 new enhancement

'mk_add_options' or 'export' MOZILLA_OFFICIAL

Reported by: sysrqb Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In #27472, we added export MOZILLA_OFFICIAL=1 in .mozconfig-android because we found the compiled APK wasn't releasable (it was still debuggable). This was due to MOZILLA_OFFICIAL not being set correctly at build-time. After exporting MOZILLA_OFFICIAL, the resulting APK is for release. Do we need both mk_add_options and export or do we only need export? Should we use export on the desktop builds, too?

Child Tickets

Change History (2)

comment:1 in reply to:  description Changed 8 months ago by reportUrl

Replying to sysrqb:

In #27472, we added export MOZILLA_OFFICIAL=1 in .mozconfig-android because we found the compiled APK wasn't releasable (it was still debuggable). This was due to MOZILLA_OFFICIAL not being set correctly at build-time. After exporting MOZILLA_OFFICIAL, the resulting APK is for release. Do we need both mk_add_options and export or do we only need export?

Where did you get that mk_add_options trash? From pre-esr era? Mozilla removed almost all occurences of it, read https://dxr.mozilla.org/mozilla-esr60/source/build/docs/mozconfigs.rst#31

Should we use export on the desktop builds, too?

Not you, but tbb-team, and long ago. That's #27623 now.

Note: See TracTickets for help on using tickets.