Opened 14 months ago

Closed 4 weeks ago

#27493 closed enhancement (fixed)

'mk_add_options' or 'export' MOZILLA_OFFICIAL

Reported by: sysrqb Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201909R, tbb-9.0-must-alpha
Cc: sysrqb Actual Points: 0.1
Parent ID: #30320 Points: 0.1
Reviewer: Sponsor:

Description

In #27472, we added export MOZILLA_OFFICIAL=1 in .mozconfig-android because we found the compiled APK wasn't releasable (it was still debuggable). This was due to MOZILLA_OFFICIAL not being set correctly at build-time. After exporting MOZILLA_OFFICIAL, the resulting APK is for release. Do we need both mk_add_options and export or do we only need export? Should we use export on the desktop builds, too?

Child Tickets

Change History (18)

comment:1 in reply to:  description Changed 14 months ago by reportUrl

Replying to sysrqb:

In #27472, we added export MOZILLA_OFFICIAL=1 in .mozconfig-android because we found the compiled APK wasn't releasable (it was still debuggable). This was due to MOZILLA_OFFICIAL not being set correctly at build-time. After exporting MOZILLA_OFFICIAL, the resulting APK is for release. Do we need both mk_add_options and export or do we only need export?

Where did you get that mk_add_options trash? From pre-esr era? Mozilla removed almost all occurences of it, read https://dxr.mozilla.org/mozilla-esr60/source/build/docs/mozconfigs.rst#31

Should we use export on the desktop builds, too?

Not you, but tbb-team, and long ago. That's #27623 now.

comment:3 Changed 3 months ago by gk

Parent ID: #30429

That'll be done in #30429.

comment:4 Changed 7 weeks ago by gk

Keywords: TorBrowserTeam201902 tbb-9.0-must-alpha added
Points: 0.25

comment:5 Changed 7 weeks ago by gk

Points: 0.250.1

comment:6 Changed 7 weeks ago by cypherpunks

TorBrowserTeam201902 0_o

comment:7 Changed 7 weeks ago by gk

Keywords: TorBrowserTeam201909 added; TorBrowserTeam201902 removed

comment:8 Changed 7 weeks ago by gk

Parent ID: #30429#30320

comment:10 Changed 7 weeks ago by cypherpunks

+ac_add_options --enable-rust-simd?

comment:11 in reply to:  7 ; Changed 7 weeks ago by gk

Keywords: TorBrowserTeam201909R added; TorBrowserTeam201909 removed
Status: newneeds_review

Replying to gk:

bug_27493 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_27493&id=e361790e2540af786386b6a13ac9477d82267db7) has the changes. I still need to test them.

This works for me.

comment:12 in reply to:  10 Changed 7 weeks ago by gk

Replying to cypherpunks:

+ac_add_options --enable-rust-simd?

That could be done in a different bug if Mozilla set it in ESR 68. However, I don't see that to be the case.

comment:14 Changed 6 weeks ago by gk

#31308 is duplicate.

comment:15 Changed 6 weeks ago by cypherpunks

Yes, Mozilla sets it and LTO in ESR 68.

comment:16 Changed 4 weeks ago by gk

Cc: sysrqb added

#31813 is duplicate.

comment:17 in reply to:  11 ; Changed 4 weeks ago by sysrqb

Status: needs_reviewmerge_ready

Replying to gk:

Replying to gk:

bug_27493 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_27493&id=e361790e2540af786386b6a13ac9477d82267db7) has the changes. I still need to test them.

This works for me.

This looks good to me. The change is deleting non-existant options, deleting deprecated syntax, deleting comments, or adding ac_add_options --enable-proxy-bypass-protection.

comment:18 in reply to:  17 Changed 4 weeks ago by gk

Actual Points: 0.1
Resolution: fixed
Status: merge_readyclosed

Replying to sysrqb:

Replying to gk:

Replying to gk:

bug_27493 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_27493&id=e361790e2540af786386b6a13ac9477d82267db7) has the changes. I still need to test them.

This works for me.

This looks good to me. The change is deleting non-existant options, deleting deprecated syntax, deleting comments, or adding ac_add_options --enable-proxy-bypass-protection.

Thanks! Merged to master (commit ec79824470dcd6815ffd903c8c9974808859f9e5).

Note: See TracTickets for help on using tickets.