Opened 3 months ago

Closed 3 months ago

#27506 closed defect (fixed)

In RTL languages, the onboarding bubble covers the version info

Reported by: mcs Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-8.0-issues, tbb-onboarding, ux-team, tbb-8.0.1-can, l10n
Cc: emmapeel Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When a right-to-left language is used, the onboarding bubble is (correctly) moved to the right side of the about:tor page. Unfortunately, the Tor Browser version information is not moved and so it is covered by the onboarding bubble. I will attach a screenshot.

Child Tickets

Attachments (2)

about-tor RTL.png (161.4 KB) - added by mcs 3 months ago.
Farsi about:tor
version_text_ar.png (54.4 KB) - added by arthuredelstein 3 months ago.

Download all attachments as: .zip

Change History (8)

Changed 3 months ago by mcs

Attachment: about-tor RTL.png added

Farsi about:tor

comment:1 Changed 3 months ago by mcs

Here is an example:
Farsi about:tor

comment:2 Changed 3 months ago by antonela

Seems like a css update can fix it.

#torstatus-version {text-align:left; left: 6px;}

am I missing anything? is something else needed?

thanks mcs!

comment:3 Changed 3 months ago by gk

Keywords: tbb-8.0.1-can added

Changed 3 months ago by arthuredelstein

Attachment: version_text_ar.png added

comment:4 Changed 3 months ago by arthuredelstein

Status: newneeds_review

Yes to CSS! Here's a patch for review:

https://github.com/arthuredelstein/torbutton/commit/27506

And a screenshot with this patch (in Arabic):

comment:5 Changed 3 months ago by emmapeel

Cc: emmapeel added
Keywords: l10n added

comment:6 Changed 3 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good to me. I cherry-picked the fix to master (commit 2754f4d06268c18e9121de41e436335a6946efc5). I think this actually fixed my original #14520. So, closing that one as well.

Note: See TracTickets for help on using tickets.