DuckDuckGo can't be used without JS in Tor Browser 8 anymore

It seems we have the regression that the DuckDuckGo search engine can't be used without JavaScript anymore. This got reported on out blog: https://blog.torproject.org/comment/276659#comment-276659.

added GeorgKoppen201809 TorBrowserTeam201809 component::applications/tor browser noscript owner::tbb-team priority::medium severity::normal status::needs-revision tbb-8.0-issues tbb-8.0.1-can tbb-regression type::defect labels

this occur with me, but after first startup just

Windows 10 64-bits 1803 17134.228

Trac:
Username: h1n1

this happen all time a set high security level in TB and don't close and reopen TB

Trac:
Username: h1n1

is another problem related to noscript-TB communication

Trac:
Username: h1n1

Trac:
Cc: N/A to arthuredelstein

Marking for 8.0.1 can.

Trac:
Keywords: N/A deleted, tbb-8.0.1-can added

Trac:
Keywords: N/A deleted, GeorgKoppen201809 added

Hm, I am not sure anymore why I removed the html part from DDG in #19898 (moved), maybe mcs/brade have some memory about that? But my patch is adding it back again as it solves this bug (see bug_27507 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_27507&id=ea6f3ec3ec41a953827e103a0f68f3d2d4fc237a) in my public Torbutton repo). Moreover, it solves the issue that a user on #tor had today, that just hitting the arrow in the search bar without entering any search term would get a white DDG page (which is arguably a DDG bug).

Trac:
Status: new to needs_review
Cc: arthuredelstein to arthuredelstein, mcs, brade
Keywords: N/A deleted, TorBrowserTeam201809R added

Replying to gk:

Hm, I am not sure anymore why I removed the html part from DDG in #19898 (moved), maybe mcs/brade have some memory about that?

We don't remember, but the change might have been made to get more DDG features such as being able to filter to show images or by timeframe.

But my patch is adding it back again as it solves this bug (see bug_27507 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_27507&id=ea6f3ec3ec41a953827e103a0f68f3d2d4fc237a) in my public Torbutton repo). Moreover, it solves the issue that a user on #tor had today, that just hitting the arrow in the search bar without entering any search term would get a white DDG page (which is arguably a DDG bug).

Your patch looks fine, but I wonder if we should ask DDG to fix their bug instead.

Replying to mcs:

Replying to gk:

Hm, I am not sure anymore why I removed the html part from DDG in #19898 (moved), maybe mcs/brade have some memory about that?

We don't remember, but the change might have been made to get more DDG features such as being able to filter to show images or by timeframe.

Yes, I think you are right.

But my patch is adding it back again as it solves this bug (see bug_27507 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_27507&id=ea6f3ec3ec41a953827e103a0f68f3d2d4fc237a) in my public Torbutton repo). Moreover, it solves the issue that a user on #tor had today, that just hitting the arrow in the search bar without entering any search term would get a white DDG page (which is arguably a DDG bug).

Your patch looks fine, but I wonder if we should ask DDG to fix their bug instead.

Actually, I should have read the comments in this bug closer. h1n1 is right I think. The issue only occurs once you set the slider to "Safest" and start using DuckDuckGo.

Trac:
Keywords: TorBrowserTeam201809R deleted, noscript, TorBrowserTeam201809 added
Status: needs_review to needs_revision

1. start TB
2. set safest security level
3. search at duckduckgo it will break than close and reopen it will works TB is requiring reopening for work properly at safety level

Trac:
Username: h1n1

this occurs every time that put at safest level I have to close and reopen for work properly

Trac:
Username: h1n1

moved to tpo/applications/tor-browser#27507 (closed)