Opened 8 months ago

Last modified 7 months ago

#27507 needs_revision defect

DuckDuckGo can't be used without JS in Tor Browser 8 anymore

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: noscript, tbb-8.0-issues, tbb-regression, tbb-8.0.1-can, GeorgKoppen201809, TorBrowserTeam201809
Cc: arthuredelstein, mcs, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

It seems we have the regression that the DuckDuckGo search engine can't be used without JavaScript anymore. This got reported on out blog: https://blog.torproject.org/comment/276659#comment-276659.

Child Tickets

Change History (11)

comment:1 Changed 8 months ago by h1n1

this occur with me, but after first startup just

Windows 10 64-bits 1803 17134.228

Last edited 8 months ago by h1n1 (previous) (diff)

comment:2 Changed 8 months ago by h1n1

this happen all time a set high security level in TB and don't close and reopen TB

comment:3 Changed 8 months ago by h1n1

is another problem related to noscript-TB communication

comment:4 Changed 8 months ago by arthuredelstein

Cc: arthuredelstein added

comment:5 Changed 8 months ago by gk

Keywords: tbb-8.0.1-can added

Marking for 8.0.1 can.

comment:6 Changed 7 months ago by gk

Keywords: GeorgKoppen201809 added

comment:7 Changed 7 months ago by gk

Cc: mcs brade added
Keywords: TorBrowserTeam201809R added
Status: newneeds_review

Hm, I am not sure anymore why I removed the html part from DDG in #19898, maybe mcs/brade have some memory about that? But my patch is adding it back again as it solves this bug (see bug_27507 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_27507&id=ea6f3ec3ec41a953827e103a0f68f3d2d4fc237a) in my public Torbutton repo). Moreover, it solves the issue that a user on #tor had today, that just hitting the arrow in the search bar without entering any search term would get a white DDG page (which is arguably a DDG bug).

comment:8 in reply to:  7 ; Changed 7 months ago by mcs

Replying to gk:

Hm, I am not sure anymore why I removed the html part from DDG in #19898, maybe mcs/brade have some memory about that?

We don't remember, but the change might have been made to get more DDG features such as being able to filter to show images or by timeframe.

But my patch is adding it back again as it solves this bug (see bug_27507 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_27507&id=ea6f3ec3ec41a953827e103a0f68f3d2d4fc237a) in my public Torbutton repo). Moreover, it solves the issue that a user on #tor had today, that just hitting the arrow in the search bar without entering any search term would get a white DDG page (which is arguably a DDG bug).

Your patch looks fine, but I wonder if we should ask DDG to fix their bug instead.

comment:9 in reply to:  8 Changed 7 months ago by gk

Keywords: noscript TorBrowserTeam201809 added; TorBrowserTeam201809R removed
Status: needs_reviewneeds_revision

Replying to mcs:

Replying to gk:

Hm, I am not sure anymore why I removed the html part from DDG in #19898, maybe mcs/brade have some memory about that?

We don't remember, but the change might have been made to get more DDG features such as being able to filter to show images or by timeframe.

Yes, I think you are right.

But my patch is adding it back again as it solves this bug (see bug_27507 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_27507&id=ea6f3ec3ec41a953827e103a0f68f3d2d4fc237a) in my public Torbutton repo). Moreover, it solves the issue that a user on #tor had today, that just hitting the arrow in the search bar without entering any search term would get a white DDG page (which is arguably a DDG bug).

Your patch looks fine, but I wonder if we should ask DDG to fix their bug instead.

Actually, I should have read the comments in this bug closer. h1n1 is right I think. The issue only occurs once you set the slider to "Safest" and start using DuckDuckGo.

comment:10 Changed 7 months ago by h1n1

  1. start TB
  2. set safest security level
  3. search at duckduckgo

it will break
than close and reopen
it will works
TB is requiring reopening for work properly at safety level

comment:11 Changed 7 months ago by h1n1

this occurs every time that put at safest level
I have to close and reopen for work properly

Note: See TracTickets for help on using tickets.