Opened 14 months ago

Closed 5 weeks ago

Last modified 5 weeks ago

#27511 closed enhancement (fixed)

Add New identity button to toolbar

Reported by: isnaiter Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ux-team, tbb-newnym, tbb-9.0-must-alpha, TorBrowserTeam201910R
Cc: antonela, lg Actual Points: 0.75
Parent ID: #10760 Points: 0.5
Reviewer: Sponsor: Sponsor9

Description

Please, make possible to put a "new identity button" in the toolbar.

Child Tickets

Attachments (5)

forget.png (144.3 KB) - added by acat 4 months ago.
27511.png (192.8 KB) - added by antonela 7 weeks ago.
27511-1.png (167.4 KB) - added by antonela 6 weeks ago.
New Identity Icon-2.svg (2.1 KB) - added by antonela 6 weeks ago.
New Identity Icon.svg (5.4 KB) - added by antonela 6 weeks ago.

Download all attachments as: .zip

Change History (34)

comment:1 Changed 14 months ago by rl1987

Component: - Select a componentApplications/Tor Browser
Owner: set to tbb-team

comment:2 Changed 14 months ago by gk

Resolution: duplicate
Status: newclosed

Yes, we are working on that during our security slider redesign. This is done in #25658, thus marking this bug as a duplicate.

comment:3 Changed 11 months ago by gk

Cc: antonela added
Keywords: ux-team tbb-newnym added
Resolution: duplicate
Status: closedreopened
Summary: New identity buttonAdd New identity button to toolbar

Actually we might want to think about New Identity in this bug and about how we could expose it better in Tor Browser.

comment:4 Changed 8 months ago by gk

Parent ID: #10760

comment:5 Changed 8 months ago by gk

Cc: lg added

Marked #29827 as duplicate.

comment:6 Changed 8 months ago by lg

Will it be possible to remove this button? I want it hidden deep down somewhere to prevent accidential clicks (yes I know that you have to confirm but it is very easy to click Yes without thinking).

And rename the whole thing. What is "new identity"? It is very unclear.

comment:7 in reply to:  6 Changed 8 months ago by gk

Replying to lg:

Will it be possible to remove this button? I want it hidden deep down somewhere to prevent accidential clicks (yes I know that you have to confirm but it is very easy to click Yes without thinking).

Yes, as with any toolbar button you can hide it by customizing the toolbar.

And rename the whole thing. What is "new identity"? It is very unclear.

I agree. We'll rename it as well.

comment:8 Changed 6 months ago by pili

Sponsor: Sponsor9

Changed 4 months ago by acat

Attachment: forget.png added

comment:9 Changed 4 months ago by acat

Just a suggestion, in case you find it useful.

Perhaps you already know, I saw via Customize... this Forget UI (attached screenshot). It does something apparently similar to New identity, ends up closing all windows and opening a new one, but of course does much less stuff under the hoods than New Identity. I think this Forget makes less sense than New identity for most Tor Browser users, and was thinking whether it would make sense to recycle it and convert it into the new New Identity exposed in toolbar. I guess this would replace the current New identity prompt, since there is already some explanation (that we could extend) and a button to confirm.

comment:10 Changed 4 months ago by cypherpunks

Forget makes sense in per-site scenario only (to avoid NI when some site behaves bad). But this request was ignored.
NI makes sense until Multiple Identities can be adopted. And no toolbar button, please.

comment:11 Changed 3 months ago by gk

Keywords: TorBrowserTeam201908 tbb-9.0-must-alpha added

comment:12 Changed 2 months ago by gk

Keywords: TorBrowserTeam201909 added; TorBrowserTeam201908 removed

Moving must-alpha tickets to September.

comment:13 Changed 2 months ago by gk

Priority: MediumHigh

comment:14 Changed 2 months ago by pili

Points: 0.5

comment:15 Changed 2 months ago by antonela

A while ago, I dropped some ideas at a similar TBA ticket.

https://trac.torproject.org/projects/tor/ticket/28800#comment:8

What do you think? When do you think users need a New Identity? When do you think users actually *use* a New Identity?

comment:16 in reply to:  15 ; Changed 2 months ago by gk

Replying to antonela:

A while ago, I dropped some ideas at a similar TBA ticket.

https://trac.torproject.org/projects/tor/ticket/28800#comment:8

What do you think?

I think that comment makes sense to me. I am totally fine with renaming that feature as "New Identity" might be a concept that's too hard to grasp. So, anything that's easier here to understand and does the same under the hood is a win in my opinion.

For the remaining dev questions:
1) ephemeral tabs: that could be an idea but we should discuss it in a different ticket, not one related to new identity as I would assume both might live together in the browser (i.e. the ephemeral tabs would not replace New Identity)

2) New Identity on TBA: Yes, TBA should replicate the behavior as we have it on desktop (although that's not relevant for this bug)

3) New Identity without closing the window: I am afraid it's already hard to get rid of all browser state the way we are doing it right now. So, to be sure we get rid of all window state the only option we have so far is closing the window and create a new one. We might get away from that requirement if we audited all the relevant parts properly but that's a tricky task and would definitely be something for a new ticket.

When do you think users need a New Identity?

That's hard to generalize as it depends on the browsing behavior and context they are in, whether they have JavaScript enabled, whether they shut down their Tor Browser regularly anyway because they power down their laptop at least once a day etc. I think it could be worth answering that question in the context of different personas instead of in a generalized manner.

When do you think users actually *use* a New Identity?

Dunno. Right now probably not very often as it is buried in some menu (which I hope we can change by putting it on the toolbar). I think users knowing about the concept might use it if they don't want to have sessions where the logged in correlated (e.g. after doing their online banking and getting asked by the bank to close the tab/session).

Changed 7 weeks ago by antonela

Attachment: 27511.png added

comment:17 Changed 7 weeks ago by antonela

As we signed the last meeting, I worked in some options to choose:

  1. This is Firefox's Delete icon. I included it as an option; some of the reasons are described here.
  1. As suggested by acat in comment:9, I've tried a version with the Firefox's Forget icon. We experienced some issues in the past using Firefox's feature icon (Tor Browser Security Settings shield vs. Firefox Content Blocking shield). My recommendation is not using the same icon Firefox is using for different features. Instead of being simpler for users, it becomes confusing. If Firefox's Forget feature becomes at some point a Tor Browser's New Identity, then we can share icons.
  1. I did a Clean icon here. Some of the reasons are described here. It could work.
  1. I did a literal New Identity icon, with a regular ID and a plus icon.

We're not renaming this feature in this iteration. Maybe, is a path to explore during TB 9.5.

https://trac.torproject.org/projects/tor/raw-attachment/ticket/27511/27511.png

Last edited 6 weeks ago by antonela (previous) (diff)

comment:18 in reply to:  16 Changed 7 weeks ago by antonela

Replying to gk:

For the remaining dev questions:
1) ephemeral tabs: that could be an idea but we should discuss it in a different ticket, not one related to new identity as I would assume both might live together in the browser (i.e. the ephemeral tabs would not replace New Identity)

True. Perhaps a discussion between persistent and ephemeral features in Tor Browser is the best way to contain these questions.

2) New Identity on TBA: Yes, TBA should replicate the behavior as we have it on desktop (although that's not relevant for this bug)

Right. We have #28800 for it.

3) New Identity without closing the window: I am afraid it's already hard to get rid of all browser state the way we are doing it right now. So, to be sure we get rid of all window state the only option we have so far is closing the window and create a new one. We might get away from that requirement if we audited all the relevant parts properly but that's a tricky task and would definitely be something for a new ticket.

Let's see if we have the capacity to think about it during TB9.5.

Last edited 7 weeks ago by antonela (previous) (diff)

comment:19 in reply to:  17 Changed 6 weeks ago by gk

Replying to antonela:

As we signed the last meeting, I worked in some options to choose:

  1. This is Firefox's Delete icon. I included it as an option; some of the reasons are described here.
  1. As suggested by acat in comment:9, I've tried a version with the Firefox's Forget icon. We experienced some issues in the past using Firefox's feature icon (Tor Browser Security Settings shield vs. Firefox Content Blocking shield). My recommendation is not using the same icon Firefox is using for different features. Instead of being simpler for users, it becomes confusing. If Firefox's Forget feature becomes at some point a Tor Browser's New Identity, then we can share icons.
  1. I did a Clean icon here. Some of the reasons are described here. It could work.
  1. I did a literal New Identity icon, with a regular ID and a plus icon.

We're not renaming this feature in this iteration. Maybe, is a path to explore during TB 9.5.

https://trac.torproject.org/projects/tor/raw-attachment/ticket/27511/27511.png

Thanks! I've no strong opinions here. I could go with any of the options.

Last edited 6 weeks ago by antonela (previous) (diff)

comment:20 Changed 6 weeks ago by pili

Keywords: TorBrowserTeam201910 added

comment:21 Changed 6 weeks ago by pili

Keywords: TorBrowserTeam201909 removed

Changed 6 weeks ago by antonela

Attachment: 27511-1.png added

comment:22 Changed 6 weeks ago by antonela

As we discussed in the last meeting, I've iterated concepts 3 and 4. Now, the broom looks more like a broom and the id seems more like an id :)

https://trac.torproject.org/projects/tor/raw-attachment/ticket/27511/27511-1.png

I have a small inclination for the broom. I'm happy to go with any of those options. I'm currently cleaning the .svg, so will attach both icons asap.

Changed 6 weeks ago by antonela

Attachment: New Identity Icon-2.svg added

Changed 6 weeks ago by antonela

Attachment: New Identity Icon.svg added

comment:23 Changed 6 weeks ago by acat

Patches for review: https://github.com/acatarineu/tor-browser/commit/27511 and https://github.com/acatarineu/torbutton/commit/27511.

I moved some code and resources from torbutton to tor-browser, I hope I did not miss anything.

Although it was not part of the plan, I also added New Tor Circuit for this site to customizable UI, but not visible by default. Just in case someone wants to have that button somewhere. I think we don't lose anything :)

comment:24 Changed 6 weeks ago by acat

Keywords: TorBrowserTeam201910R added; TorBrowserTeam201910 removed
Status: reopenedneeds_review

comment:25 in reply to:  23 Changed 5 weeks ago by gk

Keywords: TorBrowserTeam201910 added; TorBrowserTeam201910R removed
Status: needs_reviewneeds_revision

Replying to acat:

Patches for review: https://github.com/acatarineu/tor-browser/commit/27511 and https://github.com/acatarineu/torbutton/commit/27511.

I moved some code and resources from torbutton to tor-browser, I hope I did not miss anything.

Although it was not part of the plan, I also added New Tor Circuit for this site to customizable UI, but not visible by default. Just in case someone wants to have that button somewhere. I think we don't lose anything :)

Good idea. Could you mention that in your commit message as well?

The Torbutton changes look good to me. For the tor-browser ones I have some nits:

1) Please change

+    if (currentTorVersion < 1) {

to

+    if (currentTorVersion < 1 && gSavedState.placements) {

to follow the pattern in the code block (and checking for placements is good in itself).

2) We have a shortcut for the New Identity button. Could you add that one to the tooltip, too? It's done for the reload button in Firefox and seems to be a good idea.

Otherwise we are good.

comment:26 Changed 5 weeks ago by acat

For 2) it's done in https://searchfox.org/mozilla-esr68/rev/61d633e53a2bb8b66832cccb1baf7f5a6ae2c3c6/browser/base/content/browser.js#7403, and I think we would need new strings (unless we assume the key shortcut always goes at the end between parentheses, which probably is not always the case). Should we still do it? Perhaps I'm missing an easier way.

comment:27 Changed 5 weeks ago by acat

Keywords: TorBrowserTeam201910R added; TorBrowserTeam201910 removed
Status: needs_revisionneeds_review

Revised: https://github.com/acatarineu/tor-browser/commit/27511+1.

Opened #32006 for adding the key shortcut in the tooltips later.

comment:28 Changed 5 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks, looks good now. I cherry-picked the Torbutton patch to master (commit 3509fb9c4e9db216066a0d102f37d9e3d1434ef0) and the tor-browser one to tor-browser-68.1.0esr-9.0-2 (commit 1a1a15edd4288a852610ddc173bac9442c367c50)

(I just realized that I wanted to fix up the Torbutton bug number in the commit message to avoid a roundtrip and you needing to touch the Torbutton patch again, but I forgot. My bad. :( )

comment:29 Changed 5 weeks ago by acat

Actual Points: 0.75

Oops, sorry for the bug number...

Note: See TracTickets for help on using tickets.