Opened 9 months ago

Closed 8 months ago

#27545 closed defect (implemented)

hs-v3: Shuffle the client authorization ordering in the descriptor

Reported by: dgoulet Owned by:
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, 035-must
Cc: Actual Points:
Parent ID: #27544 Points:
Reviewer: Sponsor:

Description

It would be desirable to shuffle the list of clients in a descriptor (if any) so no one can learn anything from the ordering.

haxxpop has already done code for this:
https://github.com/haxxpop/tor/commit/3ac776bd988

This can go post 035 freeze.

Child Tickets

Change History (4)

comment:1 Changed 8 months ago by dgoulet

Status: newneeds_review

Basically taking haxxpop commit into a clean branch: ticket27545_035_01

comment:2 Changed 8 months ago by nickm

I think this is fine, but 1) should it have a changes file? and 2) will it disturb anything else in the code that might depend on the order of the list? If not, I say let's just merge.

comment:3 Changed 8 months ago by dgoulet

1) I don't think so, we never released client auth.

2) I believe not. Our unit tests are happy and we never used that list and thus its ordering before.

comment:4 Changed 8 months ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Okay; merged it to master.

Note: See TracTickets for help on using tickets.