Opened 6 weeks ago

Closed 5 weeks ago

Last modified 3 days ago

#27546 closed defect (fixed)

Vertical scrollbar is broken on Linux in Tor Browser 8 with Gtk3

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-8.0-issues, tbb-regression, TorBrowserTeam201809R, GeorgKoppen201809, tbb-backported
Cc: boklm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

From the blog (https://blog.torproject.org/comment/276915#comment-276915):

Vertical scrollbar behavior is broken (Linux Mint, XFCE). This has been a known issue with GTK that is resolved by creating a settings.ini file in .config/gtk-3.0/ (see: https://support.mozilla.org/en-US/questions/1120904). This fix doesn't work in Tor Browser 8.0. 

Child Tickets

Change History (9)

comment:1 Changed 5 weeks ago by gapegas7uftp

Also experiencing this issue on Linux. Expected behavior is

left click = scroll 1 page up / down;
middle-click = warp.

Other GTK application on my system work this way, but not tor browser.

comment:2 Changed 5 weeks ago by gapegas7uftp

I creating a file, tor-browser_LANGUAGE/Browser/.config/gtk-3.0/settings.ini with the content

[Settings]
gtk-primary-button-warps-slider = false

and can confirm that this creates the desired scrollbar eperience. Maybe the person complaining make the settings.ini file in the home directory, instead of where tor browser installed / Browser/.config/gtk-3.0? I think that don't work.

I am using KDE on ubuntu.

Could you make this be the default for tor browser 8, so it is like tor browser 7? (no regress)

Thanks

comment:3 in reply to:  1 Changed 5 weeks ago by cypherpunks_reply

Replying to gapegas7uftp:

Also experiencing this issue on Linux. Expected behavior is

left click = scroll 1 page up / down;
middle-click = warp.

Other GTK application on my system work this way, but not tor browser.

Replying to gapegas7uftp:

Could you make this be the default for tor browser 8, so it is like tor browser 7? (no regress)

This is not my experience. For me tor browser 7 warped with a left click and scrolled 1 page up/down with a right click (and also with shift + left click). So for me your proposal would a change.

I am using KDE on ubuntu.

I am not. This is on Debian sid.

For reference, I looked at the behaviour of some native GTK+ 3 applications on my system (mate-terminal, pluma, mate-system-monitor, gnome-terminal, evince, vim-gtk3):

  • left click: warp
  • right click and hold: constant scrolling, control speed with horizontal movement, release to stop
  • middle click: scroll 1 page
  • shift + left click: scroll 1 page
  • the button can be dragged with either left or middle click, but not right click

Then some native GTK+ 2 applications (gimp, audacity):

  • left click: warp
  • right click: scroll 1 page
  • middle click does nothing
  • shift doesn't affect behaviour
  • the button can be dragged with either left, right, or middle click

Then some XUL applications (firefox 62, thunderbird 60, tor browser 7.5.6):

  • left click: warp
  • right click: scroll 1 page
  • middle click does nothing
  • shift + left click: scroll 1 page
  • the button can be dragged with either left or right click, but not middle click

I don't dislike and am used to the above described behaviour of GTK+ 3 applications.

Last edited 5 weeks ago by cypherpunks_reply (previous) (diff)

comment:4 Changed 5 weeks ago by gk

Keywords: TorBrowserTeam201809R GeorgKoppen201809 added
Status: newneeds_review

I think we can test this in the next alpha. Here is a patch up for review: bug_27546 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_27546&id=b631035963355fba426285ca889f3cb9042433d8) in my public tor-browser-build repo.

comment:5 in reply to:  4 Changed 5 weeks ago by boklm

Status: needs_reviewneeds_revision

Replying to gk:

I think we can test this in the next alpha. Here is a patch up for review: bug_27546 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_27546&id=b631035963355fba426285ca889f3cb9042433d8) in my public tor-browser-build repo.

I think it would be more clear if we named this file something like gtk3-settings.ini instead of just settings.ini. Other than this, the patch looks good to me.

comment:6 Changed 5 weeks ago by gk

Cc: boklm added
Status: needs_revisionneeds_review

comment:7 in reply to:  6 Changed 5 weeks ago by boklm

Resolution: fixed
Status: needs_reviewclosed

Replying to gk:

bug_27546_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_27546_v2&id=7bdbf3967110c9ba553dbacda4a1cc72cad1bbc4) has the review note addressed.

This looks good to me. I cherry-picked this patch as commit 768e2c34a7516ab6e4ce2389d76c45603c3aa2fe on master.

comment:8 Changed 5 weeks ago by gk

Keywords: tbb-backport added

comment:9 Changed 3 days ago by gk

Keywords: tbb-backported added; tbb-backport removed

Let's ship this in 8.0.3: commit 7d72590c2bac2567d176b6c11c6ac6abd39de811 on maint-8.0 has the fix.

Note: See TracTickets for help on using tickets.