Opened 4 months ago

Closed 4 months ago

#27547 closed defect (fixed)

hs-v3: Client authorization feature needs a changes file and man page

Reported by: dgoulet Owned by:
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, 035-must
Cc: asn, haxxpop Actual Points:
Parent ID: #27544 Points:
Reviewer: Sponsor:

Description

To remind ourselves that we can't release 035 without the changes file and man page entry for the v3 client authorization.

Child Tickets

Change History (5)

comment:1 Changed 4 months ago by dgoulet

Cc: asn haxxpop added
Status: newneeds_review

See branch: ticket27547_035_01.

I'm not entirely satisfied with the man page so a second opinion/help would be nice. I've actually added a "subsection" to the Hidden Service section in the manpage to explain a little bit how to configure client authorization.

Also, at this stage, we have no tools (not even "tor") to create client authorization keys and configuration thus why I haven't mentioned anything on how to create keys.

comment:2 Changed 4 months ago by asn

Status: needs_reviewneeds_revision

Review:

  • s/authoriation/authorization/
  • s/authorition/authorization/
  • I see we added a new section in the man page for client auth. We should probably specify this is only for v3.

Other than that, LGTM.

comment:3 Changed 4 months ago by dgoulet

Status: needs_revisionneeds_review

Fixup commit pushed.

comment:4 Changed 4 months ago by asn

Status: needs_reviewmerge_ready

LGTM!

comment:5 Changed 4 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

squashed and merged!

Note: See TracTickets for help on using tickets.