Opened 6 weeks ago

Closed 5 weeks ago

Last modified 3 days ago

#27552 closed defect (fixed)

Latest tor browser launcher broken on linux (CentOS 6.8)

Reported by: LinuxProbes Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-8.0-issues, tbb-regression, TorBrowserTeam201809R, tbb-backported
Cc: boklm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

tor-browser-linux64-8.0_en-US.tar.xz is broken on linux (centos-6.8). Launcher in tor-browser_en-US folder does not launch. Suspect some kind of symlink problem. PLEASE UPDATE SOON.

Child Tickets

Change History (13)

comment:1 Changed 6 weeks ago by gk

Cc: boklm added
Component: - Select a componentApplications/Tor Browser
Keywords: tbb-8.0-issues tbb-regression added
Owner: set to tbb-team
Status: newneeds_information
Summary: Latest tor browser launcher broken on linuxLatest tor browser launcher broken on linux (CentOS 6.8)

CentOS 6.8 is tricky as it does not ship a GTK3 library by default (which is required by Firefox 60). The CentOS Firefox maintainers told me that they will ship a GTK3 library specifically for the Firefox 60 ESR they ship and we could use that as well then. You should get that required library once you install Firefox 60 ESR on your system. Does that solve your issue?

What output do you get if you run ./start-tor-browser.desktop --debug in your terminal (inside tor-browser_en-US)?

comment:2 Changed 6 weeks ago by tries

CentOS 6, with firefox-60.1.0-6.el6.centos.x86_64

After extending the LD_LIBRARY_PATH of tor-browser to include the libraries bundled with the FF package in CentOS, tor-browser does start and seems to work properly.

tor-browser_en-US/Browser/firefox, prepend LD_LIBRARY_PATH with the path where CentOS FF has its library bundle. On a 64bit System, this is:

LD_LIBRARY_PATH="/usr/lib64/firefox/bundled/lib64/:$basedir/TorBrowser/Tor/"

So tor-browser should include a similar bundle of required resources.

comment:3 Changed 6 weeks ago by LinuxProbes

Could it be dangerous to privacy to include non TorBrowser libraries?

comment:4 in reply to:  3 Changed 6 weeks ago by gk

Replying to LinuxProbes:

Could it be dangerous to privacy to include non TorBrowser libraries?

I think including the Gtk3 library which CentOS 6 ships is not an issue.

comment:5 Changed 5 weeks ago by boklm

I think we could ask Centos 6 users to install the firefox package, and in our wrapper script check if we are on Centos 6 and add /usr/lib64/firefox/bundled/lib64 to LD_LIBRARY_PATH in that case.

comment:6 in reply to:  5 Changed 5 weeks ago by gk

Replying to boklm:

I think we could ask Centos 6 users to install the firefox package, and in our wrapper script check if we are on Centos 6 and add /usr/lib64/firefox/bundled/lib64 to LD_LIBRARY_PATH in that case.

We could try that (we should take the architecture into account as well as this likely makes it necessary to add a different path to LD_LIBRARY_PATH).

comment:7 Changed 5 weeks ago by gk

Status: needs_informationnew

comment:9 Changed 5 weeks ago by tries

I just downloaded the build from above comment (bug_27552/tor-browser-linux64-8.5a1_en-US.tar.xz) as a clean install (CentOS 6, 64bit).
The tor-browser does start and works as expected.

comment:10 Changed 5 weeks ago by gk

Keywords: tbb-backport added
Resolution: fixed
Status: needs_reviewclosed

Okay, let's take it for the alpha. Looks good to me. Cherry-picked to master (commit a0420227e3f10f159a40b08a70cbb8c66f64c342)

comment:11 Changed 5 weeks ago by gk

FWIW I heard from a user that this works on a 32bit machine as well.

comment:12 Changed 4 weeks ago by boklm

The commit for this ticket (a0420227e3f10f159a40b08a70cbb8c66f64c342) should also fix #27857.

comment:13 Changed 3 days ago by gk

Keywords: tbb-backported added; tbb-backport removed

Fixed in 8.0.3 with commit af1a15c5047041c0d1f8b4cef2c4aa723a1c0021 on maint-8.0.

Note: See TracTickets for help on using tickets.