Opened 12 months ago

Last modified 6 weeks ago

#27604 new defect

Relocating the Tor Browser directory is broken with Tor Browser 8

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-8.0-issues, tbb-regression, tbb-8.0.1-can, TorBrowserTeam201907
Cc: user6969, catalyst Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In Tor Browser 7 users were able to extract Tor Browser in directory foo run it and copy it over to bar and run it. Starting with Tor Browser 8 this does not seem to be possible anymore. See, for instance, the respective report on our blog: https://blog.torproject.org/comment/277011#comment-277011.

Child Tickets

Change History (15)

comment:1 Changed 11 months ago by gk

Keywords: tbb-8.0.1-can added

Marking for 8.0.1 can.

comment:2 Changed 11 months ago by mcs

Kathy and I cannot reproduce the crash, but any action that causes the browser profile to be renamed or moved breaks things. The specific problem which we observed on both macOS and Linux is that Torbutton and Tor Launcher are not loaded after a rename or move.

A workaround is to delete the extensions.json file, which contains full paths. Probably that file is supposed to be recreated automatically when the profile is moved. Webextensions do not seem to suffer the same fate even though extensions.json contains their paths as well (which are outdated after the profile move).

comment:3 Changed 10 months ago by traumschule

#28199 is a duplicate.

comment:4 Changed 7 months ago by gk

Summary: Relocating the Tor Browser directory is broken with Tor Browser 8 on LinuxRelocating the Tor Browser directory is broken with Tor Browser 8

FWIW, this happens on Windows as well it seems, see: https://blog.torproject.org/comment/279768#comment-279768

comment:5 Changed 5 months ago by gk

Cc: user6969 added

Closed #27574 and #29711 as duplicates.

comment:6 Changed 4 months ago by cypherpunks

win x64, tb 8.0.8 and still... the same...

comment:7 Changed 4 months ago by catalyst

Cc: catalyst added

comment:8 Changed 4 months ago by ayylmao

why isn't this fixed already? my tor browser is up to date and if i move the folder somewhere else than the location where i first installed it and try to launch the program i can't get it to work. i thought tor was supposed to be portable

comment:9 in reply to:  8 Changed 4 months ago by gk

Replying to ayylmao:

why isn't this fixed already? my tor browser is up to date and if i move the folder somewhere else than the location where i first installed it and try to launch the program i can't get it to work. i thought tor was supposed to be portable

It isn't fixed yet because nobody has worked on it so far. But it could be you to solve this, helping us out! It would be really appreciated.

comment:10 Changed 2 months ago by teconmoon

A more permanent workaround for me was to delete extensions.json, create an empty 0 KB file in its place, and mark it as read-only. That forced the browser to use a temporary extensions.json for each session, and kept me from having to delete the file every time the directory changed.

comment:11 in reply to:  10 Changed 2 months ago by gk

Keywords: TorBrowserTeam201906 added

Replying to teconmoon:

A more permanent workaround for me was to delete extensions.json, create an empty 0 KB file in its place, and mark it as read-only. That forced the browser to use a temporary extensions.json for each session, and kept me from having to delete the file every time the directory changed.

Wow, that's painful. I guess what we could do is patching XPIProviderUtils.js's parseDB() and add a sanity check making sure the path of the extensions in the DB exists. If not we need to recreate the DB. I suspect that would be something Mozilla would take if we upstreamed it.

We could as well just delete the json file during browser shutdown. However, that seems to be a bit too excessive.

comment:12 Changed 2 months ago by Thorin

FWIW, John Haller from PortableApps applied a fix (see https://portableapps.com/node/60299 , and comment 9), but I'm not entirely sure what he did, but also had an additional issue (see https://portableapps.com/node/60496 ) with addonStartup.json.lz4 (edit: which was added in FF67).

Let me know if you would like me to reach out to John Halter and ask what he did, but I think you know what needs to be done already, and getting this done upstream is the best solution IMO.

Update: https://portableapps.com/comment/240579#comment-240579 -> John's reply

Last edited 2 months ago by Thorin (previous) (diff)

comment:15 Changed 6 weeks ago by gk

Keywords: TorBrowserTeam201907 added; TorBrowserTeam201906 removed

Moving tickets to July

Note: See TracTickets for help on using tickets.