Opened 5 months ago

Closed 4 months ago

Last modified 4 months ago

#27625 closed defect (implemented)

add unit tests for tokenize_string() and get_next_token()

Reported by: cyberpunks Owned by: rl1987
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-unittests, tor-tests-unit
Cc: Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

It looks like there aren't any.

Child Tickets

Change History (8)

comment:1 Changed 5 months ago by nickm

Milestone: Tor: unspecified

+1

comment:2 Changed 4 months ago by rl1987

Owner: set to rl1987
Status: newaccepted

comment:3 Changed 4 months ago by rl1987

Status: acceptedneeds_review

comment:4 Changed 4 months ago by nickm

Milestone: Tor: unspecifiedTor: 0.3.6.x-final

comment:5 Changed 4 months ago by dgoulet

Reviewer: dgoulet

comment:6 Changed 4 months ago by dgoulet

Status: needs_reviewmerge_ready

This is kind of awesome!!

ACK on this.

(Note: the current dns and now adding parsecommon tests are not in alphabetical order in the test array so once merged, lets fix that quickly else when one run make test, it is not easy to spot them if they aren't ordered!)

comment:7 Changed 4 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Nice, merged! Added #28177 for re-sorting the array (there were other test groups out of order too).

comment:8 Changed 4 months ago by nickm

Milestone: Tor: 0.3.6.x-finalTor: 0.4.0.x-final

Tor 0.3.6.x has been renamed to 0.4.0.x.

Note: See TracTickets for help on using tickets.