Opened 2 months ago

Closed 2 months ago

#27658 closed defect (fixed)

Nonzero exit from forked testcase should make the testcase fail

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: catalyst Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In our unit tests, if a forked testcase crashes after having reported success (as can happen on a memory leak under lsan), the parent won't learn about it right now. That's obviously not great. Let's fix it.

Child Tickets

Change History (3)

comment:1 Changed 2 months ago by nickm

Status: assignedneeds_review

Fix in my branch bug27658_029, based on 0.2.9. PR at https://github.com/torproject/tor/pull/319

comment:2 Changed 2 months ago by dgoulet

Status: needs_reviewmerge_ready

lgtm;

comment:3 Changed 2 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merged to 0.2.9 and forward. Let's keep an eye on CI, since anything with a leak may now start failing.

Note: See TracTickets for help on using tickets.