Opened 8 years ago

Closed 6 years ago

Last modified 6 years ago

#2767 closed defect (fixed)

Another possible directory-handling bug

Reported by: rransom Owned by:
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: spec-conformance easy tor-relay tor-spec
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

2011-03-16 09:58 <tor-internal> parse_http_url() allows alone GET or POST, "If it's well-formed, strdup the second \%s" says that it's incorrect. second "eat_whitespace_no_nl" leaves nl, should be "eat_whitespace".

Child Tickets

Change History (12)

comment:1 Changed 8 years ago by nickm

Milestone: Tor: 0.2.3.x-final
Priority: majornormal

Downgrading this to normal; putting it for 0.2.3. (The bug here will make us accept certain ill-formed HTTP commands, which is not a disaster fwcit.)

comment:2 Changed 8 years ago by nickm

Keywords: spec-conformance added

comment:3 Changed 7 years ago by nickm

Keywords: easy added
Milestone: Tor: 0.2.3.x-finalTor: 0.2.4.x-final

still seems harmless albeit annoying. Punting to 0.2.4.x. I don't have the time to do it right now in a way I would be pleased with. (The way I'd be pleased with would require unit tests for the function)

comment:4 Changed 7 years ago by nickm

Keywords: tor-relay added

comment:5 Changed 7 years ago by nickm

Component: Tor RelayTor

comment:6 Changed 7 years ago by nickm

Milestone: Tor: 0.2.4.x-finalTor: 0.2.5.x-final

comment:7 Changed 6 years ago by nickm

Keywords: tor-spec added

Bulk-replacing "spec" and "torspec" keywords with "tor-spec".

comment:9 Changed 6 years ago by nickm

Status: newneeds_review

Looks mostly okay; I went to add more tests, but then I realized that it wouldn't handle HTTP/1.10 -- which doesn't exist and probably never will, but so long as we're making changes in the name of standards compliance, let's try to do them compliantly.

See branch "bug2767" in my public repository (https://git.torproject.org/nickm/tor.git) -- how does that look?

comment:10 Changed 6 years ago by Ry

Looks good to me, agreed on compliance, Thanks

comment:11 Changed 6 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Great; merged.

comment:12 Changed 6 years ago by arma

In the future: you get extra points when your changes file has a newline at the end of it. :) Otherwise when I cat the changes files together they end up all jumbled. Thanks!

Note: See TracTickets for help on using tickets.