Opened 7 months ago

Closed 5 months ago

#27686 closed defect (fixed)

OOM code should count space used in a circuit's half-closed list

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 034-backport?
Cc: mikeperry Actual Points:
Parent ID: #25573 Points:
Reviewer: ahf Sponsor:

Description

The new code in #25573 should be integrated with the circuit OOM code.

Child Tickets

Change History (7)

comment:1 Changed 7 months ago by nickm

Owner: set to nickm
Status: newaccepted

comment:2 Changed 7 months ago by nickm

Status: acceptedneeds_review

See ticket27686_034 for the branch. It's based on Mikeperry's ticket25573-034, and merges cleanly into master. There's a compilation issue post-merge, so I made ticket27686_035 to clean that up. See PR at https://github.com/torproject/tor/pull/335 . No changes file needed if we get this in before 0.3.5.1 :)

comment:3 Changed 7 months ago by asn

Reviewer: ahf

comment:4 Changed 7 months ago by ahf

Status: needs_reviewmerge_ready

PR 335 looks fine.

comment:5 Changed 7 months ago by mikeperry

Looks ok to me, too.

comment:6 Changed 7 months ago by nickm

Milestone: Tor: 0.3.5.x-finalTor: 0.3.4.x-final
Parent ID: #25573

Merged to master, marked for possible backport.

comment:7 Changed 5 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

Backported along with parent.

Note: See TracTickets for help on using tickets.