Opened 11 months ago

Closed 10 months ago

Last modified 10 months ago

#27707 closed defect (fixed)

Improve some v3 onion logs

Reported by: asn Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs easy tor-logs
Cc: Actual Points:
Parent ID: Points:
Reviewer: asn Sponsor:

Description

I've been debugging lots of v3 logs lately and I noticed a few issues with them that can be improved:

1)

set_descriptor_revision_counter(): Encrypted revision counter 118682 to -403149886

no need for %ld there, it's an uint64_t.

2) On the client side when we fetch descriptors we have the following log message that displays the onion address and blinded key as a base64 instead of the typical base32. We should unify the format to make grep easier:

[info] directory_launch_v3_desc_fetch(): Descriptor fetch request for service khXWrMUXYYW1so9/CIWe5kI7+nxcSYO9zd4Edl2IIz8 with blinded key QvyLoKg/B6musSsNfL4vMk2wD2HpiDsTU3gM7kY41Sg to directory $C0B7413D690411DF5D2B0D838F56792312697122~minitor at 185.143.62.9

Child Tickets

Change History (3)

comment:1 Changed 10 months ago by ffmancera

Status: newneeds_review

Here is a patch! Check my github branch ticket27707 :-)

comment:2 Changed 10 months ago by dgoulet

Reviewer: asn

comment:3 Changed 10 months ago by asn

Resolution: fixed
Status: needs_reviewclosed

Merged. Thanks!

(Relevant PR fwiw: https://github.com/torproject/tor/pull/453)

Last edited 10 months ago by asn (previous) (diff)
Note: See TracTickets for help on using tickets.