Opened 5 months ago
Closed 5 months ago
#27717 closed enhancement (implemented)
Report tor segfaults when integ testing
| Reported by: | atagar | Owned by: | atagar |
|---|---|---|---|
| Priority: | High | Milestone: | |
| Component: | Core Tor/Stem | Version: | |
| Severity: | Normal | Keywords: | testing easy |
| Cc: | Actual Points: | ||
| Parent ID: | Points: | ||
| Reviewer: | Sponsor: |
Description
From time to time Stem's integration tests crash tor (for example, #27500). When this happens our test output is pretty confusing since from the point of the crash onward we fail with generic 'cannot connect to tor' errors.
There's two issues here...
- Our test output doesn't indicate that tor crashed.
- When reporting tor segfaults we need its stacktrace, which is swallowed by our tests.
We should adjust our test's get_tor_controller() helper to check if tor is still alive, failing the test with a clearer message if it isn't and providing the tor stacktrace at the end of the test run.
Child Tickets
Note: See
TracTickets for help on using
tickets.
Done. Stem now provides *much* better test output when our tor process crashes...
https://gitweb.torproject.org/stem.git/commit/?id=0b734b6