Opened 9 months ago

Closed 9 months ago

#27734 closed defect (fixed)

tor on OpenSSL claims not to support LinkAuth=1

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: nickm Actual Points:
Parent ID: #27288 Points:
Reviewer: Sponsor:

Description (last modified by teor)

HAVE_WORKING_TOR_TLS_GET_TLSSECRETS is defined in tortls.h, which protover.c and test_protover.c do not include.

Therefore, every Tor on master now thinks it only supports LinkAuth=3:

#ifdef HAVE_WORKING_TOR_TLS_GET_TLSSECRETS
    "LinkAuth=1,3 "
#else
    "LinkAuth=3 "
#endif

Child Tickets

Change History (5)

comment:1 Changed 9 months ago by teor

Summary: tor on OpenSSL doesn't supports LinkAuth=1tor on OpenSSL claims not to support LinkAuth=1

typo

comment:2 Changed 9 months ago by teor

Description: modified (diff)

another typo

comment:3 Changed 9 months ago by nickm

Commit b729bc202c7411 should fix this; I'll leave open till we confirm. thanks for speedy diagnosis!

comment:4 Changed 9 months ago by teor

Status: newmerge_ready

I'm going to mark this as "merge_ready", because the commit has been merged.
("New" is confusing.)

comment:5 Changed 9 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

This was indeed fixed by the commit above.

Note: See TracTickets for help on using tickets.