Tors with cached consensuses can't upgrade to a version that stops supporting a required protocol

When Tor loads the cached consensus, it checks the protocols in that consensus, and then exits if it does not have any required protocols. These checks happen before signatures and expiry are checked. (And before trying to get a new consensus.)

This makes it impossible for a Tor with a cached consensus to stop supporting a protocol required in that consensus.

changed milestone to %Tor: 0.4.0.x-final

added 029-unreached-backport-maybe 032-unreached-backport-maybe 033-unreached-backport-maybe 034-unreached-backport-maybe actualpoints::.3 component::core tor/tor milestone::Tor: 0.4.0.x-final owner::nickm priority::high prop297 resolution::implemented reviewer::ahf severity::normal status::closed type::defect labels

Proposal 297 is my proposal for what to do here: https://gitweb.torproject.org/torspec.git/plain/proposals/297-safer-protover-shutdowns.txt

Unparenting.

Trac:
Parent: #27288 (moved) to N/A

Trac:
Status: new to accepted
Owner: N/A to nickm
Priority: Medium to High

On analysis, I think it's safe to defer this to 0.3.6. This only comes up when we are possibly about to drop support for a protocol, and we aren't planning to drop any more protocols in 0.3.5.

Trac:
Milestone: Tor: 0.3.5.x-final to Tor: 0.3.6.x-final

Tor 0.3.6.x has been renamed to 0.4.0.x.

Trac:
Milestone: Tor: 0.3.6.x-final to Tor: 0.4.0.x-final

0.3.2 is end of life, so 032-backport is now 032-unreached-backport.

Trac:
Keywords: N/A deleted, 032-unreached-backport added

Tag 032-backport-maybe with 032-unreached-backport-maybe

Trac:
Keywords: 032-backport-maybe deleted, 032-unreached-backport-maybe added

Remove redundant 032-unreached-backport on 032-unreached-backport-maybe

Trac:
Keywords: 032-unreached-backport deleted, N/A added

See branch prop297, PR at https://github.com/torproject/tor/pull/541 .

This code updates the update_versions script to automatically keep the version dates moving forward with each release. (It also rewrites update_versions in Python, to be less horrible.)

Trac:
Status: accepted to needs_review
Actualpoints: N/A to .3
Keywords: N/A deleted, prop297 added

Trac:
Reviewer: N/A to ahf

Very nice. Looks good.

Trac:
Status: needs_review to merge_ready

Merged, and updated torspec as 18fcb9ab42cca4ce963202a22cd1f93f68ecd57c

Trac:
Status: merge_ready to closed
Resolution: N/A to implemented

Trac:
Keywords: 029-backport-maybe, 033-backport-maybe, 034-backport-maybe deleted, 033-unreached-backport-maybe, 029-unreached-backport-maybe, 034-unreached-backport-maybe added

closed

added 2h 24m of time spent

moved to tpo/core/tor#27735 (closed)