Changes between Version 1 and Version 2 of Ticket #27740, comment 15


Ignore:
Timestamp:
Oct 24, 2018, 7:58:12 PM (12 months ago)
Author:
cyberpunks
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #27740, comment 15

    v1 v2  
    22> (Does that look okay?)
    33
    4 No, [https://gitweb.torproject.org/tor.git/commit/?id=289a7dbac32a981897e12a3c250f0b6c67eec809 that merge] completely undid the whole diff in [https://gitweb.torproject.org/tor.git/commit/?id=42558df7c8affeec33e66d987ccf4d632a9d5466 42558df7c8affeec33e66d987ccf4d632a9d5466] that fixed this bug. It's right back to creating a CString and then calling `CString::into_raw()` which as the commit summary notes is not safe.
     4No, [https://gitweb.torproject.org/tor.git/commit/?id=289a7dbac32a981897e12a3c250f0b6c67eec809 that merge] completely undid the whole diff in [https://gitweb.torproject.org/tor.git/commit/?id=42558df7c8affeec33e66d987ccf4d632a9d5466 42558df7c8affeec33e66d987ccf4d632a9d5466] that fixed this bug. It's right back to creating a Rust-allocated `CString` and then calling `CString::into_raw()` which as the commit summary notes is not safe.