Use message.__meta to talk to NoScript

For talking to NoScript we are using right now message._messageName which is deprecated. We should start using the newer message.__meta.

rustybird wrote a patch for that over in #27427 (moved) and Arthur rebased and reviewed it:

https://github.com/arthuredelstein/torbutton/commits/27427_alpha

added TorBrowserTeam201809R component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::normal status::closed tbb-backported type::defect labels

Trac:
Status: new to merge_ready

Merged to master (commit ec1c0f448893775b660313042709a9b057b3ab75). I reverted the message._messageName-patch in commit 59f3b78349d8de267cf69fb8873971ff0d9ecf7b as that one is obsolete with the patches in this bug.

Trac:
Resolution: N/A to fixed
Status: merge_ready to closed
Keywords: N/A deleted, tbb-backport added

Trac:
Username: rustybird

Receive-startup-message-using-NoScript-10.1.9.2-protocol.patch

Trac:
Username: rustybird

Arthur, turns out your branch contained a wrong patch. I fixed that by reverting the bad commit (which was efdc83fec6244d5f2e4b8880fef010a6e362d9dc) and cherry-picking rustybird's original patch (this is now commit 6016a170f0266cf926b7ff305796ba83cc353536).

Replying to gk:

Arthur turns out your branch contained a wrong patch. I fixed that by reverting the bad commit (which was efdc83fec6244d5f2e4b8880fef010a6e362d9dc) and cherry-picking rustybird's original patch (this is now commit 6016a170f0266cf926b7ff305796ba83cc353536).

Oh, that was fast. Please ignore Receive-startup-message-using-NoScript-10.1.9.2-protocol.patch which I uploaded before your comment.

Trac:
Username: rustybird

Torbutton 2.0.8, included in Tor Browser 8.0.3, will have those fixes which are on maint-2.0 in the Torbutton repo now.

Trac:
Keywords: tbb-backport deleted, tbb-backported added

closed

moved to tpo/applications/tor-browser#27760 (closed)