Opened 3 months ago

Closed 3 months ago

Last modified 2 months ago

#27760 closed defect (fixed)

Use message.__meta to talk to NoScript

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201809R, tbb-backported
Cc: ma1, arthuredelstein, rustybird Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

For talking to NoScript we are using right now message._messageName which is deprecated. We should start using the newer message.__meta.

rustybird wrote a patch for that over in #27427 and Arthur rebased and reviewed it:

https://github.com/arthuredelstein/torbutton/commits/27427_alpha

Child Tickets

Attachments (1)

Receive-startup-message-using-NoScript-10.1.9.2-protocol.patch (993 bytes) - added by rustybird 3 months ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 3 months ago by gk

Status: newmerge_ready

comment:2 Changed 3 months ago by gk

Keywords: tbb-backport added
Resolution: fixed
Status: merge_readyclosed

Merged to master (commit ec1c0f448893775b660313042709a9b057b3ab75). I reverted the message._messageName-patch in commit 59f3b78349d8de267cf69fb8873971ff0d9ecf7b as that one is obsolete with the patches in this bug.

comment:3 Changed 3 months ago by gk

Arthur, turns out your branch contained a wrong patch. I fixed that by reverting the bad commit (which was efdc83fec6244d5f2e4b8880fef010a6e362d9dc) and cherry-picking rustybird's original patch (this is now commit 6016a170f0266cf926b7ff305796ba83cc353536).

Last edited 3 months ago by gk (previous) (diff)

comment:4 in reply to:  3 Changed 3 months ago by rustybird

Replying to gk:

Arthur turns out your branch contained a wrong patch. I fixed that by reverting the bad commit (which was efdc83fec6244d5f2e4b8880fef010a6e362d9dc) and cherry-picking rustybird's original patch (this is now commit 6016a170f0266cf926b7ff305796ba83cc353536).

Oh, that was fast. Please ignore Receive-startup-message-using-NoScript-10.1.9.2-protocol.patch which I uploaded before your comment.

comment:5 Changed 2 months ago by gk

Keywords: tbb-backported added; tbb-backport removed

Torbutton 2.0.8, included in Tor Browser 8.0.3, will have those fixes which are on maint-2.0 in the Torbutton repo now.

Last edited 2 months ago by gk (previous) (diff)
Note: See TracTickets for help on using tickets.