Opened 4 months ago

Last modified 27 hours ago

#27761 merge_ready enhancement

check-changes: check that bugfixes aren't on future versions

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: fast-fix
Cc: Actual Points:
Parent ID: Points:
Reviewer: nickm Sponsor:

Description

I tried to modify lintChanges.py to check for bugfixes against future versions. But then I realised that we backport bugfixes.

So I salvaged the version parsing code into a new check.

Child Tickets

Change History (6)

comment:1 Changed 4 months ago by teor

Status: assignedneeds_review

See my branch ticket27761 at https://github.com/teor2345/tor.git

I don't mind if this goes in 0.3.5 or 0.3.6.
Tentatively assigning 0.3.5 because it's part of "make check".

comment:2 in reply to:  description ; Changed 4 months ago by cypherpunks3

Replying to teor:

I tried to modify lintChanges.py to check for bugfixes against future versions. But then I realised that we backport bugfixes.

So I salvaged the version parsing code into a new check.

But don't you only backport bugfixes to versions that already have the bug?

comment:3 in reply to:  2 Changed 4 months ago by teor

Summary: check-changes: check that bugfix versions have 3 numbers in themcheck-changes: check that bugfixes aren't on future versions

Replying to cypherpunks3:

Replying to teor:

I tried to modify lintChanges.py to check for bugfixes against future versions. But then I realised that we backport bugfixes.

So I salvaged the version parsing code into a new check.

But don't you only backport bugfixes to versions that already have the bug?

You're right, yes, we do. (But I bet we've got that wrong in the past, and backported bugfixes that say they're for a later version.)

All the current changes files pass this new check, so let's see how we go.

See my branch ticket27761, or https://github.com/torproject/tor/pull/353 .

I also tested that "bugfix on 0.3.5.1-alpha" works, but 0.3.5.2-alpha and 0.4.5.1-alpha fail the check.

I backported the change to 0.2.9 and 0.3.2, to check that their changes files pass this new check:

(But I don't think we need to backport this change.)

comment:4 Changed 4 months ago by nickm

I had a couple of minor python questions on the PR. Other than that, it looks fine.

I wonder, is it time for us to add test cases for check_changes? (Doesn't have to be you, doesn't have to be this ticket)

comment:5 Changed 4 months ago by nickm

Reviewer: nickm
Status: needs_reviewneeds_revision

comment:6 Changed 27 hours ago by nickm

Status: needs_revisionmerge_ready

I've made the changes I requested as a ticket27761 branch, with a PR as https://github.com/torproject/tor/pull/653 . If it passes CI, I'll merge after 0.4.0.1-alpha.

Note: See TracTickets for help on using tickets.