Opened 3 months ago

Closed 8 days ago

#27762 closed defect (fixed)

Implement better fix for Torbutton signing workaround

Reported by: gk Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, TorBrowserTeam201812R
Cc: Legion, sysrqb, igt0 Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In #27271 we implemented a workaround for mobile related to the Torbutton signing exemption. We should think about a cleaner fix as mentioned in comment:7:ticket:27271.

There I noted

FWIW: ​https://bugzilla.mozilla.org/show_bug.cgi?id=1464766 landed in esr60 and might be a thing to consider here.

Child Tickets

Attachments (1)

0001-Bug-27762-Remove-workarounds-that-allowed-torbutton-.patch (1.8 KB) - added by igt0 8 days ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 8 weeks ago by gk

Cc: Legion added
Priority: MediumHigh

Marked #28059 as duplicate.

comment:2 Changed 12 days ago by gk

Cc: sysrqb igt0 added

I think we can just back out/revert our previous patches, now that Torbutton is not a standalone extension anymore on mobile

comment:3 Changed 12 days ago by gk

Keywords: TorBrowserTeam201811 added

comment:4 Changed 12 days ago by igt0

Indeed, I reverted all the patches and the system extension worked fine.

comment:5 in reply to:  4 Changed 9 days ago by gk

Keywords: TorBrowserTeam201812 added; TorBrowserTeam201811 removed

Replying to igt0:

Indeed, I reverted all the patches and the system extension worked fine.

Great. Could you prepare a branch so we can include it in the release on 12/11?

comment:6 Changed 8 days ago by igt0

Status: newneeds_review

comment:7 Changed 8 days ago by gk

Keywords: TorBrowserTeam201812R added; TorBrowserTeam201812 removed

comment:8 Changed 8 days ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Applied to tor-browser-60.3.0esr-8.5-1 (commit 057daaf3fa81f46d4a3653115990b462fe7b2551). I'll just skip all three patches when rebasing to 60.4.0 ESR to not pile up more and more patches which are not needed anymore.

Note: See TracTickets for help on using tickets.