Opened 2 months ago

Closed 4 weeks ago

#27797 closed defect (fixed)

node: Make node_supports_v3_rendezvous_point() also check for the onion_pk

Reported by: dgoulet Owned by:
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, tor-relay, 033-backport, 034-backport
Cc: asn Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Turns out that we think this is related to #27774.

A client selects a v3 RP by only looking at the protover but it is possible that at that time we simply don't have the descriptor yet thus missing the onion_pk which led to a failure when sending the INTRODUCE1 cell.

Like node_supports_ed25519_link_authentication() does, we should simply check for the onion_pk as an extra step to the protover.

Flagging this for backport.

Child Tickets

Change History (10)

comment:1 Changed 2 months ago by dgoulet

Cc: asn added
Status: newneeds_review

Branch: ticket27797_035_01
PR: https://github.com/torproject/tor/pull/361

comment:2 Changed 2 months ago by asn

Status: needs_reviewmerge_ready

LGTM!

comment:3 Changed 2 months ago by nickm

Backport candidate? if so, please make a branch based on 0.3.2

comment:4 Changed 2 months ago by dgoulet

032 branch: ticket27797_032_01
The 035 branch merges without conflict on 033 and onward: ticket27797_035_01

comment:5 Changed 2 months ago by nickm

Milestone: Tor: 0.3.5.x-finalTor: 0.3.4.x-final

merged to 0.3.5, marking for possible backport

comment:6 Changed 2 months ago by dgoulet

Parent ID: #27774

Unparenting so we can close the parent hopefully in 035.

comment:7 Changed 4 weeks ago by asn

Please backport this to 034. dgoulet's 035 branch from comment:4 merges fine to 034.

comment:8 Changed 4 weeks ago by nickm

dgoulet's 035 branch from comment:4 merges fine to 034

Do you mean I should cherry-pick it? It _is_ based on 0.3.5. Merging it to 0.3.4 would make for trouble.

comment:9 Changed 4 weeks ago by dgoulet

Here is an 034 branch with the fix cherry picked from the 035 branch: ticket27797_034_01.

comment:10 Changed 4 weeks ago by nickm

Resolution: fixed
Status: merge_readyclosed

merged!

Note: See TracTickets for help on using tickets.