Opened 4 weeks ago

Closed 4 weeks ago

#27799 closed task (implemented)

Split routerlist.c and dirserv.c into smaller modules

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

These are a couple of the biggest modules in Tor, and they have a bunch of responsibilities each.

Per discussion, we're going to try to put more code movement into 0.3.5, to reduce the number of code-movement releases we need to merge across.

See branch split_routerlist_dirserv with PR at https://github.com/torproject/tor/pull/363 .

Child Tickets

Change History (3)

comment:1 Changed 4 weeks ago by nickm

Status: assignedneeds_review

comment:2 Changed 4 weeks ago by dgoulet

Status: needs_reviewneeds_revision

I think this is great. Some questions:

I would be consistent on a file name that have _fmt for which it should be either at the start or end, doesn't matter, just that we have the same standard for all files.

fmt_serverstatus.c
routerstatus_fmt.c

The other thing that confuses me is:

  * recv_descs.c handles fingerprint files and processing incoming
    routerinfos that relays upload to us

The recv_descs.c file name seems to suggest to me that it is about receiving descriptors, not "handling" them per se. I would suggest using something around the lines of handle_desc.c or using the term "decision" somehow to show that the code in that file is about decision making of descriptors, not parsing, not I/O, not storing or "receiving".

comment:3 Changed 4 weeks ago by nickm

Resolution: implemented
Status: needs_revisionclosed

Made requested changes and merged!

Note: See TracTickets for help on using tickets.