Opened 15 months ago

Last modified 7 months ago

#27854 needs_information enhancement

Integration test(s) for tor-resolve

Reported by: rl1987 Owned by: rl1987
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Normal Keywords: socks, tor-resolve, testing, 041-deferred-20190530
Cc: Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description


Child Tickets

Change History (18)

comment:1 Changed 15 months ago by rl1987

Type: defectenhancement

comment:2 Changed 15 months ago by rl1987

Owner: set to rl1987
Status: newaccepted

comment:3 Changed 15 months ago by rl1987

WIP: https://github.com/torproject/tor/pull/375

Need to figure out how to integrate this stuff into build system.

comment:4 Changed 14 months ago by rl1987

Nick says it would be better to code up a mock SOCKS server that pretends to be Tor in Python and use it to test tor-resolve. Using LD_PRELOAD isn't exactly portable.

comment:5 Changed 13 months ago by rl1987

Status: acceptedneeds_review

comment:6 Changed 13 months ago by rl1987

Status: needs_reviewaccepted

comment:7 Changed 13 months ago by rl1987

Two CI jobs fail - need to address this.

comment:8 Changed 13 months ago by nickm

Milestone: Tor: 0.3.6.x-finalTor: 0.4.0.x-final

Tor 0.3.6.x has been renamed to 0.4.0.x.

comment:9 Changed 13 months ago by nickm

Parent ID: #27620

Unparenting.

comment:10 Changed 11 months ago by rl1987

Status: acceptedneeds_review

comment:11 Changed 10 months ago by dgoulet

Reviewer: dgoulet

comment:12 Changed 10 months ago by dgoulet

Status: needs_reviewneeds_information

I keep getting this from running the .sh:

+ uname -s
+ cut -d_ -f1
+ UNAME_OS=Linux
+ test Linux = CYGWIN
+ test Linux = MSYS
+ test Linux = MINGW
+ test  = clang
+ exitcode=0
+ python ./src/test/test_resolve.py ./src/tools/tor-resolve
.
Exception in thread Thread-2:
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner
    self.run()
  File "/usr/lib/python2.7/threading.py", line 754, in run
    self.__target(*self.__args, **self.__kwargs)
  File "./src/test/test_resolve.py", line 57, in mock_server
    s.bind(("127.0.0.1", socks_port))
  File "/usr/lib/python2.7/socket.py", line 228, in meth
    return getattr(self._sock,name)(*args)
error: [Errno 98] Address already in use

Traceback (most recent call last):
  File "./src/test/test_resolve.py", line 140, in <module>
    t.run()
  File "./src/test/test_resolve.py", line 101, in run
    assert l == self.expect_final_stdout
AssertionError
+ exitcode=1
+ exit 1

comment:13 Changed 10 months ago by rl1987

Does this happen on every run, or on some runs?

comment:14 Changed 10 months ago by nickm

Milestone: Tor: 0.4.0.x-finalCollecTor 1.7.0

comment:15 Changed 10 months ago by rl1987

Also, do you happen to be compiling with clang on Linux?

comment:16 Changed 10 months ago by nickm

Milestone: CollecTor 1.7.0Tor: 0.4.1.x-final

comment:17 Changed 7 months ago by nickm

Keywords: 041-deferred-20190530 added

Marking these tickets as deferred from 041.

comment:18 Changed 7 months ago by nickm

Milestone: Tor: 0.4.1.x-finalTor: unspecified
Note: See TracTickets for help on using tickets.